Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Unified Diff: src/hydrogen.h

Issue 14838012: Revert r14610 because of test-262 failures. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/hydrogen.h
diff --git a/src/hydrogen.h b/src/hydrogen.h
index e5d83377ac0e7f53d48c364d6b313204322dc283..a95424a1c9e455ffa4a9664770844aee75b28b7d 100644
--- a/src/hydrogen.h
+++ b/src/hydrogen.h
@@ -934,7 +934,6 @@ class HGraphBuilder {
: info_(info),
graph_(NULL),
current_block_(NULL),
- no_side_effects_scope_environment_delta_(0),
no_side_effects_scope_count_(0) {}
virtual ~HGraphBuilder() {}
@@ -966,31 +965,11 @@ class HGraphBuilder {
HReturn* AddReturn(HValue* value);
void IncrementInNoSideEffectsScope() {
- if (no_side_effects_scope_count_ == 0) {
- no_side_effects_scope_environment_delta_ =
- environment()->push_count() - environment()->pop_count();
- }
no_side_effects_scope_count_++;
}
void DecrementInNoSideEffectsScope() {
no_side_effects_scope_count_--;
- if (no_side_effects_scope_count_ == 0) {
- // No-side-effects scope should not change push-pop delta.
- ASSERT_EQ(no_side_effects_scope_environment_delta_,
- environment()->push_count() - environment()->pop_count());
- no_side_effects_scope_environment_delta_ = 0;
- }
- }
-
- bool SafeToAddPhiInNoSideEffectsScope() {
- // Pops and pushes after a simulate are not visible in LChunkBuilder.
- // If the number of pops is greater than the number pushes then the
- // environment in HGraphBuilder is shorter then the corresponding
- // environment in LChunkBuilder. This causes non-observable phis
- // to be pushed in the environment, which breaks deoptimization.
- return no_side_effects_scope_count_ == 0 ||
- no_side_effects_scope_environment_delta_ >= 0;
}
protected:
@@ -1353,7 +1332,6 @@ class HGraphBuilder {
CompilationInfo* info_;
HGraph* graph_;
HBasicBlock* current_block_;
- int no_side_effects_scope_environment_delta_;
int no_side_effects_scope_count_;
};
« no previous file with comments | « no previous file | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698