Files.app: Fixed the problem that dialog opened by Ctrl+O cannot be expand.

Files.app: Fixed the problem that dialog opened by Ctrl+O cannot be expand.

To initialize the widget that contains dialog correctly, preferred
size of dialog should be set before.

BUG=238865
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199658

[hirono, 2013-05-08 06:07:19]

Hello sky,

Could you check this CL fixing a bug that dialog opened by Ctrl+O cannot be
expand.

Thank you very much.

[sky, 2013-05-08 16:14:42]

https://codereview.chromium.org/14837004/diff/1/chrome/browser/ui/views/exten...
File chrome/browser/ui/views/extensions/extension_dialog.cc (right):

https://codereview.chromium.org/14837004/diff/1/chrome/browser/ui/views/exten...
chrome/browser/ui/views/extensions/extension_dialog.cc:60: int minWidth,
min_width, min_height

How do we know we can trust these values? What happens if they are ginormous or
too small?

https://codereview.chromium.org/14837004/diff/1/chrome/browser/ui/views/exten...
File chrome/browser/ui/views/extensions/extension_dialog.h (right):

https://codereview.chromium.org/14837004/diff/1/chrome/browser/ui/views/exten...
chrome/browser/ui/views/extensions/extension_dialog.h:45: int minWidth,
min_width, min_height

[hirono, 2013-05-09 02:23:16]

I fixed variable names.
Thank you very much!

https://codereview.chromium.org/14837004/diff/1/chrome/browser/ui/views/exten...
File chrome/browser/ui/views/extensions/extension_dialog.cc (right):

https://codereview.chromium.org/14837004/diff/1/chrome/browser/ui/views/exten...
chrome/browser/ui/views/extensions/extension_dialog.cc:60: int minWidth,
On 2013/05/08 16:14:42, sky wrote:
> min_width, min_height
> 
> How do we know we can trust these values? What happens if they are ginormous
or
> too small?

Actually these arguments are added just for calling
NativeViewHost::SetPreferredSize. So how to deal with these values is
depending on each NativeViewHost. Currently ExtensionDialog::Show
is only used from SelectFileDialogExtension and constant values are
passed as these arguments there.

https://codereview.chromium.org/14837004/diff/1/chrome/browser/ui/views/exten...
File chrome/browser/ui/views/extensions/extension_dialog.h (right):

https://codereview.chromium.org/14837004/diff/1/chrome/browser/ui/views/exten...
chrome/browser/ui/views/extensions/extension_dialog.h:45: int minWidth,
On 2013/05/08 16:14:42, sky wrote:
> min_width, min_height

Done.

[sky, 2013-05-09 15:51:57]

https://codereview.chromium.org/14837004/diff/1/chrome/browser/ui/views/exten...
File chrome/browser/ui/views/extensions/extension_dialog.cc (right):

https://codereview.chromium.org/14837004/diff/1/chrome/browser/ui/views/exten...
chrome/browser/ui/views/extensions/extension_dialog.cc:60: int minWidth,
On 2013/05/09 02:23:16, hirono wrote:
> On 2013/05/08 16:14:42, sky wrote:
> > min_width, min_height
> > 
> > How do we know we can trust these values? What happens if they are ginormous
> or
> > too small?
> 
> Actually these arguments are added just for calling
> NativeViewHost::SetPreferredSize. So how to deal with these values is
> depending on each NativeViewHost. Currently ExtensionDialog::Show
> is only used from SelectFileDialogExtension and constant values are
> passed as these arguments there.

I was assuming these values are coming from script on a page. If the values
aren't coming from the page then I agree with you.

[hirono, 2013-05-10 02:05:58]

I tried "git grep ExtensionDialog::Show".
According to the result of grep, this function is used from only
SelectFileDialogExtension, where these values are not coming from the page.

On 2013/05/09 15:51:57, sky wrote:
>
https://codereview.chromium.org/14837004/diff/1/chrome/browser/ui/views/exten...
> File chrome/browser/ui/views/extensions/extension_dialog.cc (right):
> 
>
https://codereview.chromium.org/14837004/diff/1/chrome/browser/ui/views/exten...
> chrome/browser/ui/views/extensions/extension_dialog.cc:60: int minWidth,
> On 2013/05/09 02:23:16, hirono wrote:
> > On 2013/05/08 16:14:42, sky wrote:
> > > min_width, min_height
> > > 
> > > How do we know we can trust these values? What happens if they are
ginormous
> > or
> > > too small?
> > 
> > Actually these arguments are added just for calling
> > NativeViewHost::SetPreferredSize. So how to deal with these values is
> > depending on each NativeViewHost. Currently ExtensionDialog::Show
> > is only used from SelectFileDialogExtension and constant values are
> > passed as these arguments there.
> 
> I was assuming these values are coming from script on a page. If the values
> aren't coming from the page then I agree with you.

[sky, 2013-05-10 15:46:32]

LGTM

[hirono, 2013-05-13 01:28:13]

On 2013/05/10 15:46:32, sky wrote:
> LGTM

Thank you!

[commit-bot: I haz the power, 2013-05-13 01:28:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/14837004/6001

[commit-bot: I haz the power, 2013-05-13 05:13:39]

Change committed as 199658