Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 14836006: Deprecate Carts in Wallet code. (Closed)

Created:
7 years, 7 months ago by ahutter
Modified:
7 years, 6 months ago
Reviewers:
Ilya Sherman, Dan Beam
CC:
chromium-reviews, Raman Kakilate, benquan, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, Ilya Sherman
Visibility:
Public.

Description

Carts are deprecated by the latest version of the server BUG=240333 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203852

Patch Set 1 #

Patch Set 2 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -142 lines) Patch
M chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc View 1 4 chunks +0 lines, -12 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
D components/autofill/browser/wallet/cart.h View 1 chunk +0 lines, -50 lines 0 comments Download
D components/autofill/browser/wallet/cart.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D components/autofill/browser/wallet/cart_unittest.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M components/autofill/browser/wallet/wallet_client.h View 3 chunks +0 lines, -5 lines 0 comments Download
M components/autofill/browser/wallet/wallet_client.cc View 3 chunks +0 lines, -5 lines 0 comments Download
M components/autofill/browser/wallet/wallet_client_unittest.cc View 1 8 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ahutter
Ilya and Dan, PTAL. Thanks.
7 years, 7 months ago (2013-05-13 17:45:43 UTC) #1
Ilya Sherman
LGTM, but please change the CL description to something more like: """Deprecate Carts in Wallet ...
7 years, 7 months ago (2013-05-13 22:52:25 UTC) #2
Dan Beam
lgtm, most excellent
7 years, 7 months ago (2013-05-17 04:49:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ahutter@chromium.org/14836006/2001
7 years, 6 months ago (2013-06-03 23:38:26 UTC) #4
commit-bot: I haz the power
7 years, 6 months ago (2013-06-04 05:53:57 UTC) #5
Message was sent while issue was closed.
Change committed as 203852

Powered by Google App Engine
This is Rietveld 408576698