Updated iossim output path to use $(SYMROOT).

Updated iossim output path to use $(SYMROOT).

Previously it was hardcoded to use the xcodebuild folder.

BUG=NONE

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198112

[lliabraa, 2013-05-03 10:18:21]

On 2013/05/03 00:33:35, sanjeevr wrote:

This looks like it will work, but can you give some more context so I can
understand the issue? There may be other places where we're not using SYMROOT
but should be.

[sanjeevr, 2013-05-03 13:38:00]

Sure, SYMROOT is the environment variable used by XCode to denote the root
of the output folder (
https://developer.apple.com/library/mac/#documentation/DeveloperTools/Referen...).
SYMROOT is set to  '<(DEPTH)/xcodebuild' in common.gypi. However when
building from the command-line using xcodebuild, it is possible to override
SYMROOT to point to a totally different location. So it would be better to
use that instead of hardcoding the path.

If you look at src/testing/gtest_ios/run-unittest.sh, it used $(BUILD_DIR)
to find the location of iossim. BUILD_DIR is set by XCode based on SYMROOT
(actually it would probably make sense to use SYMROOT instead of BUILD_DIR
in that file too).


On Fri, May 3, 2013 at 3:18 AM, <lliabraa@chromium.org> wrote:

> On 2013/05/03 00:33:35, sanjeevr wrote:
>
> This looks like it will work, but can you give some more context so I can
> understand the issue? There may be other places where we're not using
> SYMROOT
> but should be.
>
>
https://codereview.chromium.**org/14835006/<https://codereview.chromium.org/1...
>

[lliabraa, 2013-05-03 14:02:40]

LGTM - thanks for the clarification.

[commit-bot: I haz the power, 2013-05-03 14:08:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sanjeevr@chromium.org/14835006/1

[commit-bot: I haz the power, 2013-05-03 15:39:50]

Change committed as 198112