Issue 14828011: Mark zero dimension textures as unrenderable

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14828011: Mark zero dimension textures as unrenderable (Closed)

Created:
7 years, 7 months ago by greggman

Modified:
7 years, 6 months ago

Reviewers:
no sievers

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Mark zero dimension textures as unrenderable BUG=240961 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200717

Patch Set 3 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -24 lines)			Patch
M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc	View		8 chunks	+8 lines, -8 lines	0 comments	Download
M	gpu/command_buffer/service/texture_manager.h	View		6 chunks	+12 lines, -8 lines	0 comments	Download
M	gpu/command_buffer/service/texture_manager.cc	View	1 2	5 chunks	+36 lines, -3 lines	0 comments	Download
M	gpu/command_buffer/service/texture_manager_unittest.cc	View	1	2 chunks	+16 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

no sievers

lgtm https://codereview.chromium.org/14828011/diff/10001/gpu/command_buffer/service/texture_manager.cc File gpu/command_buffer/service/texture_manager.cc (right): https://codereview.chromium.org/14828011/diff/10001/gpu/command_buffer/service/texture_manager.cc#newcode177 gpu/command_buffer/service/texture_manager.cc:177: if (target_ != GL_TEXTURE_EXTERNAL_OES && nit: It can ...

7 years, 7 months ago (2013-05-17 00:25:13 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gman@chromium.org/14828011/15001

7 years, 7 months ago (2013-05-17 00:41:36 UTC) #3

Message was sent while issue was closed.

Change committed as 200717

Expand Messages | Collapse Messages

Issue 14828011: Mark zero dimension textures as unrenderable (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages