cros: Arrow key traversal in views.

ui/views/focus/focus_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/focus/focus_manager.h"
 
 #include <algorithm>
+#include <vector>
 
 #include "base/auto_reset.h"
 #include "base/logging.h"
 #include "build/build_config.h"
 #include "ui/base/accelerators/accelerator.h"
 #include "ui/base/events/event.h"
 #include "ui/base/keycodes/keyboard_codes.h"
 #include "ui/views/focus/focus_manager_delegate.h"
 #include "ui/views/focus/focus_search.h"
 #include "ui/views/focus/view_storage.h"
 #include "ui/views/focus/widget_focus_manager.h"
 #include "ui/views/view.h"
 #include "ui/views/widget/root_view.h"
 #include "ui/views/widget/widget.h"
 #include "ui/views/widget/widget_delegate.h"
 
 namespace views {
 
 bool FocusManager::shortcut_handling_suspended_ = false;
+bool FocusManager::arrow_key_traversal_enabled_ = false;
 
 FocusManager::FocusManager(Widget* widget, FocusManagerDelegate* delegate)
     : widget_(widget),
       delegate_(delegate),
       focused_view_(NULL),
       accelerator_manager_(new ui::AcceleratorManager),
       focus_change_reason_(kReasonDirectFocusChange),
       is_changing_focus_(false) {
   DCHECK(widget_);
   stored_focused_view_storage_id_ =
@@ skipping 43 matching lines @@
       AdvanceFocus(event.IsShiftDown());
       return false;
     }
 #else
     if (IsTabTraversalKeyEvent(event)) {
       AdvanceFocus(event.IsShiftDown());
       return false;
     }
 #endif
 
+    if (arrow_key_traversal_enabled_ && ProcessArrowKeyTraversal(event))
+      return false;
+
     // Intercept arrow key messages to switch between grouped views.
     if (focused_view_ && focused_view_->GetGroup() != -1 &&
         (key_code == ui::VKEY_UP || key_code == ui::VKEY_DOWN ||
          key_code == ui::VKEY_LEFT || key_code == ui::VKEY_RIGHT)) {
       bool next = (key_code == ui::VKEY_RIGHT || key_code == ui::VKEY_DOWN);
       View::Views views;
       focused_view_->parent()->GetViewsInGroup(focused_view_->GetGroup(),
                                                &views);
       View::Views::const_iterator i(
           std::find(views.begin(), views.end(), focused_view_));
@@ skipping 409 matching lines @@
 }
 
 void FocusManager::AddFocusChangeListener(FocusChangeListener* listener) {
   focus_change_listeners_.AddObserver(listener);
 }
 
 void FocusManager::RemoveFocusChangeListener(FocusChangeListener* listener) {
   focus_change_listeners_.RemoveObserver(listener);
 }
 
+bool FocusManager::ProcessArrowKeyTraversal(const ui::KeyEvent& event) {
+  if (event.IsShiftDown() || event.IsControlDown() || event.IsAltDown())
+    return false;
+
+  const int key_code = event.key_code();
+  if (key_code == ui::VKEY_LEFT || key_code == ui::VKEY_UP) {
+    AdvanceFocus(true);
+    return true;
+  }
+  if (key_code == ui::VKEY_RIGHT || key_code == ui::VKEY_DOWN) {
+    AdvanceFocus(false);
+    return true;
+  }
+
+  return false;
+}
+
 }  // namespace views