Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14823005: Remove inside_chromium_build gyp variable (Closed)

Created:
7 years, 7 months ago by jamesr
Modified:
7 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, vsevik, jam, yurys, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, apatrick_chromium, cc-bugs_chromium.org, pfeldman
Visibility:
Public.

Description

Remove inside_chromium_build gyp variable In the days of olde, we supported compiling from inside a chromium checkout and inside a WebKit checkout with some chromium libraries. In the latter configuration, used mainly by the build.webkit.org bots, the paths to the WebKit headers relative to chromium gyp files was different. This added a lot of complexity and some extra scripts to fix up paths and includes. Blink only supports building within a chromium checkout so all of this complexity can be removed. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199057

Patch Set 1 #

Total comments: 2

Patch Set 2 : sort gyps, fix ios #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -428 lines) Patch
M build/common.gypi View 5 chunks +6 lines, -22 lines 0 comments Download
M cc/cc.gyp View 2 chunks +1 line, -15 lines 0 comments Download
M content/browser/devtools/devtools_resources.gyp View 1 chunk +1 line, -10 lines 0 comments Download
M content/content.gyp View 1 2 chunks +3 lines, -17 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M content/content_renderer.gypi View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_shell.gypi View 1 1 chunk +3 lines, -3 lines 0 comments Download
M content/content_tests.gypi View 1 4 chunks +5 lines, -5 lines 0 comments Download
M content/content_worker.gypi View 1 chunk +1 line, -1 line 0 comments Download
M net/net.gyp View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_internal.gyp View 1 3 chunks +7 lines, -7 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 chunk +0 lines, -9 lines 0 comments Download
M skia/skia.gyp View 2 chunks +1 line, -7 lines 0 comments Download
M ui/ui.gyp View 3 chunks +1 line, -10 lines 0 comments Download
M webkit/base/webkit_base.gypi View 2 chunks +1 line, -8 lines 0 comments Download
M webkit/compositor_bindings/compositor_bindings.gyp View 2 chunks +1 line, -8 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 5 chunks +5 lines, -19 lines 0 comments Download
M webkit/gpu/webkit_gpu.gyp View 3 chunks +2 lines, -18 lines 0 comments Download
M webkit/media/webkit_media.gypi View 3 chunks +1 line, -11 lines 0 comments Download
M webkit/storage/webkit_storage.gypi View 3 chunks +1 line, -15 lines 0 comments Download
D webkit/support/setup_third_party.gyp View 1 chunk +0 lines, -97 lines 0 comments Download
D webkit/support/setup_third_party.py View 1 chunk +0 lines, -129 lines 0 comments Download
M webkit/support/webkit_support.gypi View 1 chunk +0 lines, -7 lines 0 comments Download
M webkit/user_agent/webkit_user_agent.gypi View 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jamesr
Dirk, would you mind reviewing the gyp-ness? Darin, could you OWNERS approve?
7 years, 7 months ago (2013-05-07 23:15:09 UTC) #1
jam
drive-by this change is awesome https://codereview.chromium.org/14823005/diff/1/content/content_shell.gypi File content/content_shell.gypi (right): https://codereview.chromium.org/14823005/diff/1/content/content_shell.gypi#newcode55 content/content_shell.gypi:55: '../third_party/WebKit/Source/WebKit/chromium/WebKit.gyp:webkit', nit: order https://codereview.chromium.org/14823005/diff/1/content/content_tests.gypi ...
7 years, 7 months ago (2013-05-07 23:18:10 UTC) #2
darin (slow to review)
OWNERS rubberstamp LGTM
7 years, 7 months ago (2013-05-08 00:01:16 UTC) #3
Dirk Pranke
yay cleanup. double-yay no more third-party headers. lgtm.
7 years, 7 months ago (2013-05-08 01:02:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/14823005/27
7 years, 7 months ago (2013-05-08 14:19:54 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-08 23:52:46 UTC) #6
Message was sent while issue was closed. 
Change committed as 199057

Powered by Google App Engine
This is Rietveld 408576698