roll cacheinvalidation forward to @302

roll cacheinvalidation forward to @302

Summary of changes:

- Use a random value for the token-assignment nonce instead of the current time.

- Add RandUint64 to the Random class and override.

TBR=brettw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198756

[rlarocque, 2013-05-02 17:38:09]

https://codereview.chromium.org/14822002/diff/1/third_party/cacheinvalidation...
File
third_party/cacheinvalidation/overrides/google/cacheinvalidation/deps/random.h
(right):

https://codereview.chromium.org/14822002/diff/1/third_party/cacheinvalidation...
third_party/cacheinvalidation/overrides/google/cacheinvalidation/deps/random.h:10:
#define INT64_MAX 9223372036854775807L
Could you rely on base/basictypes.h instead?  It defines kint64max.

If that won't work, how about std::numeric_limits<int64>?

https://codereview.chromium.org/14822002/diff/1/third_party/cacheinvalidation...
third_party/cacheinvalidation/overrides/google/cacheinvalidation/deps/random.h:22:
virtual double RandDouble() {
I see in r299 you use this to generate a random string.  base/rand_util.h has a
RandBytes function that might be more convenient, if you can expose it through
this API.

(It might be more correct, too.  I think the method used to generate the random
string will have less than the 63 bits of randomness that the nearby comment
claims it has.)

[ghc, 2013-05-03 03:29:00]

https://codereview.chromium.org/14822002/diff/1/third_party/cacheinvalidation...
File
third_party/cacheinvalidation/overrides/google/cacheinvalidation/deps/random.h
(right):

https://codereview.chromium.org/14822002/diff/1/third_party/cacheinvalidation...
third_party/cacheinvalidation/overrides/google/cacheinvalidation/deps/random.h:10:
#define INT64_MAX 9223372036854775807L
On 2013/05/02 17:38:09, rlarocque wrote:
> Could you rely on base/basictypes.h instead?  It defines kint64max.
> 
> If that won't work, how about std::numeric_limits<int64>?

Removed this and added a RandUint64 call, which is easy to implement.

https://codereview.chromium.org/14822002/diff/1/third_party/cacheinvalidation...
third_party/cacheinvalidation/overrides/google/cacheinvalidation/deps/random.h:22:
virtual double RandDouble() {
On 2013/05/02 17:38:09, rlarocque wrote:
> I see in r299 you use this to generate a random string.  base/rand_util.h has
a
> RandBytes function that might be more convenient, if you can expose it through
> this API.
> 
> (It might be more correct, too.  I think the method used to generate the
random
> string will have less than the 63 bits of randomness that the nearby comment
> claims it has.)

(See above comment.)

[rlarocque, 2013-05-03 17:20:43]

Thanks, that looks much better.  LGTM.

https://codereview.chromium.org/14822002/diff/5001/third_party/cacheinvalidat...
File
third_party/cacheinvalidation/overrides/google/cacheinvalidation/deps/random.h
(right):

https://codereview.chromium.org/14822002/diff/5001/third_party/cacheinvalidat...
third_party/cacheinvalidation/overrides/google/cacheinvalidation/deps/random.h:25:
return base::RandUint64();
The Clang style-checked would normally reject this.  See
http://www.chromium.org/developers/coding-style/chromium-style-checker-errors...
.

It seems that the style-checker isn't being run over this file, otherwise you
would have already run into problems with the RandDouble() function.  

You probably should fix this sooner or later, but I won't hold up the review for
it.

[commit-bot: I haz the power, 2013-05-06 20:02:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ghc@google.com/14822002/5001

[ghc, 2013-05-06 20:12:33]

https://codereview.chromium.org/14822002/diff/5001/third_party/cacheinvalidat...
File
third_party/cacheinvalidation/overrides/google/cacheinvalidation/deps/random.h
(right):

https://codereview.chromium.org/14822002/diff/5001/third_party/cacheinvalidat...
third_party/cacheinvalidation/overrides/google/cacheinvalidation/deps/random.h:25:
return base::RandUint64();
On 2013/05/03 17:20:43, rlarocque wrote:
> The Clang style-checked would normally reject this.  See
>
http://www.chromium.org/developers/coding-style/chromium-style-checker-errors...
> .
> 
> It seems that the style-checker isn't being run over this file, otherwise you
> would have already run into problems with the RandDouble() function.  
> 
> You probably should fix this sooner or later, but I won't hold up the review
for
> it.  

Yeah, let's address that in a follow-on CL.  This is apparently blocking Android
from rolling forward.

[commit-bot: I haz the power, 2013-05-06 20:13:51]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[rlarocque, 2013-05-06 20:42:20]

On 2013/05/06 20:13:51, I haz the power (commit-bot) wrote:
> Retried try job too often on chromium_presubmit for step(s) presubmit
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

Looks like they've added stronger enforcement of OWNERS rules.  According to
third_party/OWNERS, you need to TBR= one of brettw@, cpu@, or darin@.  

See also:
http://www.chromium.org/developers/testing/commit-queue#TOC-Sending-a-TBR-pat...

[commit-bot: I haz the power, 2013-05-06 20:50:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ghc@google.com/14822002/5001

[commit-bot: I haz the power, 2013-05-06 21:22:44]

Retried try job too often on ios_dbg_simulator for step(s) base_unittests,
compile, content_unittests, crypto_unittests, googleurl_unittests,
media_unittests, net_unittests, sql_unittests, ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-05-06 22:51:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ghc@google.com/14822002/5001

[commit-bot: I haz the power, 2013-05-06 23:35:49]

Retried try job too often on ios_dbg_simulator for step(s) base_unittests,
compile, content_unittests, crypto_unittests, googleurl_unittests,
media_unittests, net_unittests, sql_unittests, ui_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...

[commit-bot: I haz the power, 2013-05-07 04:36:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ghc@google.com/14822002/5001

[commit-bot: I haz the power, 2013-05-07 05:07:32]

Retried try job too often on ios_rel_device for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_de...

[commit-bot: I haz the power, 2013-05-07 17:09:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ghc@google.com/14822002/5001

[commit-bot: I haz the power, 2013-05-07 17:34:24]

Change committed as 198756

[nyquist, 2013-05-07 18:12:20]

On 2013/05/07 17:34:24, I haz the power (commit-bot) wrote:
> Change committed as 198756

Patch set 2 was the one that was committed. Please ignore Patch set 3 and 4.