Issue 14821010: DevTools: Do not unbind stylesheets in multiframe documents

Issue 14821010: DevTools: Do not unbind stylesheets in multiframe documents (Closed)

Created:
7 years, 7 months ago by apavlov

Modified:
7 years, 7 months ago

Reviewers:
vsevik

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

DevTools: Do not unbind stylesheets in multiframe documents Stylesheets from top-level document appear as removed if the activeStyleSheetsUpdated() event comes from an iframe and thus gets unbound. Multiple variations of this issue are possible, so the originating document should be taken into account to filter the bound stylesheets. BUG=238589 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149874

Patch Set 1 #

Total comments: 3

Patch Set 2 : Updated expectation #

Patch Set 3 : Add test files left behind #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+191 lines, -234 lines)			Patch
M	LayoutTests/TestExpectations	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	LayoutTests/http/tests/inspector/styles/resources/stylesheet-tracking.css	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	LayoutTests/http/tests/inspector/styles/resources/stylesheet-tracking-iframe.html	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/inspector/styles/resources/stylesheet-tracking-import.css	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/inspector/styles/resources/stylesheet-tracking-import-1.css	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/inspector/styles/resources/stylesheet-tracking-import-2.css	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download
A +	LayoutTests/http/tests/inspector/styles/stylesheet-tracking.html	View	1 2	8 chunks	+76 lines, -9 lines	0 comments	Download
A	LayoutTests/http/tests/inspector/styles/stylesheet-tracking-expected.txt	View	1 2	1 chunk	+52 lines, -0 lines	0 comments	Download
D	LayoutTests/inspector/styles/resources/stylesheet-tracking.css	View	1	1 chunk	+0 lines, -3 lines	0 comments	Download
M	LayoutTests/inspector/styles/stylesheet-tracking.html	View	1	1 chunk	+0 lines, -179 lines	0 comments	Download
M	LayoutTests/inspector/styles/stylesheet-tracking-expected.txt	View	1	1 chunk	+0 lines, -36 lines	0 comments	Download
M	Source/core/inspector/InspectorCSSAgent.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/inspector/InspectorCSSAgent.cpp	View	1	2 chunks	+11 lines, -2 lines	0 comments	Download
M	Source/core/inspector/InspectorInstrumentation.cpp	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	Source/core/inspector/InspectorInstrumentationInl.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

vsevik

lgtm https://codereview.chromium.org/14821010/diff/1/LayoutTests/inspector/styles/stylesheet-tracking.html File LayoutTests/inspector/styles/stylesheet-tracking.html (right): https://codereview.chromium.org/14821010/diff/1/LayoutTests/inspector/styles/stylesheet-tracking.html#newcode86 LayoutTests/inspector/styles/stylesheet-tracking.html:86: InspectorTest.evaluateInPage("loadIframe()"); I would also test iframe removing as ...

7 years, 7 months ago (2013-05-07 08:11:47 UTC) #2

apavlov

On 2013/05/07 08:11:47, vsevik wrote: > lgtm > > https://codereview.chromium.org/14821010/diff/1/LayoutTests/inspector/styles/stylesheet-tracking.html > File LayoutTests/inspector/styles/stylesheet-tracking.html (right): > ...

7 years, 7 months ago (2013-05-07 12:18:10 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/14821010/8001

7 years, 7 months ago (2013-05-07 14:32:00 UTC) #5

Message was sent while issue was closed.

Change committed as 149874

Expand Messages | Collapse Messages