Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14820034: Cleanup: Remove unneeded base/file_util.h includes in chrome_frame, courgette, ipc, media, and net. (Closed)

Created:
7 years, 7 months ago by Lei Zhang
Modified:
7 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, grt+watch_chromium.org, amit, jam, sail+watch_chromium.org, feature-media-reviews_chromium.org, robertshield, darin-cc_chromium.org, mmenke
Visibility:
Public.

Description

Cleanup: Remove unneeded base/file_util.h includes in chrome_frame, courgette, ipc, media, and net. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200419

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix nits, add missing includes #

Patch Set 3 : #

Patch Set 4 : fix build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -32 lines) Patch
M chrome_frame/chrome_frame_activex.cc View 1 2 3 3 chunks +2 lines, -3 lines 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M chrome_frame/utils.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M courgette/adjustment_method_unittest.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M courgette/base_test_unittest.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M courgette/base_test_unittest.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M courgette/courgette_minimal_tool.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M courgette/disassembler_win32_x86_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_nacl.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ipc/unix_domain_socket_util_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_output_win_unittest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M media/filters/blocking_url_protocol_unittest.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M net/base/sdch_filter.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M net/base/upload_element.cc View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M net/disk_cache/block_files.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/cache_creator.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/disk_cache_test_util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/mapped_file_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/storage_block_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/dns/dns_config_service_posix.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M net/test/spawned_test_server/local_test_server_win.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/tools/dump_cache/cache_dumper.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/dump_cache/cache_dumper.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M net/url_request/url_request_file_dir_job.h View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M net/url_request/url_request_http_job.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Lei Zhang
tommi: cf, courgette tsepez: ipc xhwang: media rsleevi: net stampy stampy
7 years, 7 months ago (2013-05-14 18:57:50 UTC) #1
xhwang
media lgtm w/ a comment https://codereview.chromium.org/14820034/diff/1/media/filters/blocking_url_protocol_unittest.cc File media/filters/blocking_url_protocol_unittest.cc (right): https://codereview.chromium.org/14820034/diff/1/media/filters/blocking_url_protocol_unittest.cc#newcode7 media/filters/blocking_url_protocol_unittest.cc:7: #include "base/path_service.h" you can ...
7 years, 7 months ago (2013-05-14 19:03:31 UTC) #2
Ryan Sleevi
net/ LGTM stampy.
7 years, 7 months ago (2013-05-14 19:04:12 UTC) #3
grt (UTC plus 2)
chrome_frame/ lgtm
7 years, 7 months ago (2013-05-14 19:06:42 UTC) #4
Tom Sepez
On 2013/05/14 19:06:42, grt wrote: > chrome_frame/ lgtm ipc/ LGTM.
7 years, 7 months ago (2013-05-14 19:08:22 UTC) #5
tommi (sloooow) - chröme
lgtm for courgette/* (I see Greg has already lgtm-ed the CF changes).
7 years, 7 months ago (2013-05-14 21:07:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/14820034/23001
7 years, 7 months ago (2013-05-15 01:37:00 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 7 months ago (2013-05-15 01:53:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/14820034/45001
7 years, 7 months ago (2013-05-15 20:05:17 UTC) #9
commit-bot: I haz the power
7 years, 7 months ago (2013-05-16 02:37:55 UTC) #10
Message was sent while issue was closed. 
Change committed as 200419

Powered by Google App Engine
This is Rietveld 408576698