Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1374)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14820030: Move Chrome OS switches to chromeos/chromeos_switches.cc (Closed)

Created:
7 years, 7 months ago by James Cook
Modified:
7 years, 7 months ago
Reviewers:
stevenjb, sky
CC:
chromium-reviews, dbeam+watch-options_chromium.org, cbentzel+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, ben+watch_chromium.org, nona+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, yusukes+watch_chromium.org
Visibility:
Public.

Description

Move Chrome OS switches to chromeos/chromeos_switches.cc Take them out of chrome/common/chrome_switches.cc BUG=239626 TEST=compiles TBR=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199347

Patch Set 1 #

Patch Set 2 : fix interactive_ui_tests #

Total comments: 1

Patch Set 3 : fix nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -238 lines) Patch
M chrome/browser/about_flags.cc View 9 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/background/ash_user_wallpaper_delegate.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/chrome_browser_main_chromeos.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/echo_private_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_manager_util.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/kiosk_mode/kiosk_mode_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/chrome_restart_request.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/kiosk_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/login_display_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/oobe_browsertest.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/scoped_gaia_auth_extension.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/wallpaper_manager_browsertest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/memory/oom_priority_manager.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/policy/auto_enrollment_client.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/preferences.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/cros_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/settings/device_settings_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/component_loader.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/policy/browser_policy_connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prefs/command_line_pref_store.cc View 2 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/event_rewriter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/ash/event_rewriter_unittest.cc View 6 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/ash/tab_scrubber_browsertest.cc View 1 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/oobe_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 1 chunk +0 lines, -36 lines 0 comments Download
M chrome/common/chrome_switches.cc View 2 chunks +5 lines, -114 lines 0 comments Download
M chromeos/chromeos_switches.h View 2 chunks +34 lines, -3 lines 0 comments Download
M chromeos/chromeos_switches.cc View 6 chunks +110 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
James Cook
Steven, PTAL at chrome_switches.cc and chromeos_switches.cc. Everything else should be a rubber-stamp.
7 years, 7 months ago (2013-05-09 22:17:37 UTC) #1
stevenjb
Hooray. lgtm https://chromiumcodereview.appspot.com/14820030/diff/3001/chrome/common/chrome_switches.h File chrome/common/chrome_switches.h (right): https://chromiumcodereview.appspot.com/14820030/diff/3001/chrome/common/chrome_switches.h#newcode415 chrome/common/chrome_switches.h:415: // See also src/chromeos/chromeos_switches.h nit: s/Keep*// nit: ...
7 years, 7 months ago (2013-05-09 23:20:14 UTC) #2
James Cook
sky, can I get a rubber-stamp OWNERS approval?
7 years, 7 months ago (2013-05-09 23:34:53 UTC) #3
James Cook
On 2013/05/09 23:34:53, James Cook (Chromium) wrote: > sky, can I get a rubber-stamp OWNERS ...
7 years, 7 months ago (2013-05-09 23:54:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/14820030/9001
7 years, 7 months ago (2013-05-09 23:55:13 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-10 02:56:26 UTC) #6
Message was sent while issue was closed. 
Change committed as 199347

Powered by Google App Engine
This is Rietveld 408576698