Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 14820016: Changes the order of widget Close() and DecrementDeferCounter(). (Closed)

Created:
7 years, 7 months ago by Jun Mukai
Modified:
7 years, 7 months ago
Reviewers:
Dmitry Titov, dewittj
CC:
chromium-reviews
Visibility:
Public.

Description

Changes the order of widget Close() and DecrementDeferCounter(). This is a bit tricky scenario, but the current code may lead to a mismatch of increment/decrement by calling Close(). See the bug for how the mismatch happens. BUG=238477 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198829

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M ui/message_center/views/toast_contents_view.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Jun Mukai
7 years, 7 months ago (2013-05-07 00:28:11 UTC) #1
Dmitry Titov
Awesome, great find, thanks! lgtm
7 years, 7 months ago (2013-05-07 00:49:32 UTC) #2
dewittj
lgtm - Can we get a browser test?
7 years, 7 months ago (2013-05-07 00:50:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/14820016/1
7 years, 7 months ago (2013-05-07 16:30:36 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=124979
7 years, 7 months ago (2013-05-07 16:44:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/14820016/1
7 years, 7 months ago (2013-05-07 20:55:01 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-07 23:53:51 UTC) #7
Message was sent while issue was closed.
Change committed as 198829

Powered by Google App Engine
This is Rietveld 408576698