chrome/browser/chrome_browser_main.cc - Issue 1481933002: Move crash keys for command-line switches to components/crash so they can be set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 1481933002: Move crash keys for command-line switches to components/crash so they can be set (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@installer_crash_keys

Patch Set: typedef -> using, %lu -> PRIuS[D[D[D[D[D Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chrome_browser_main.cc

diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc

index a977d342921dc6a73315df14eb765a3a05c5d275..3a41ca91b9e70a3319412353964bfc2ed759fc63 100644

--- a/chrome/browser/chrome_browser_main.cc

+++ b/chrome/browser/chrome_browser_main.cc

@@ -967,8 +967,8 @@ int ChromeBrowserMainParts::PreCreateThreadsImpl() {

// Reset the command line in the crash report details, since we may have

// just changed it to include experiments.

- crash_keys::SetSwitchesFromCommandLine(

- base::CommandLine::ForCurrentProcess());

+ crash_keys::SetCrashKeysFromCommandLine(

+ *base::CommandLine::ForCurrentProcess());

// Mac starts it earlier in |PreMainMessageLoopStart()| (because it is

// needed when loading the MainMenu.nib and the language doesn't depend on

« no previous file with comments | « chrome/app/chrome_main_delegate.cc ('k') | chrome/common/crash_keys.h » ('j') | no next file with comments »