Issue 14817004: Makes mouse-hover prevent notification toasts from moving.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14817004: Makes mouse-hover prevent notification toasts from moving. (Closed)

Created:
7 years, 7 months ago by dewittj

Modified:
7 years, 7 months ago

Reviewers:
Jun Mukai

CC:
chromium-reviews, Dmitry Titov

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Makes mouse-hover prevent notification toasts from moving. Current behavior was to move toasts down towards the taskbar after a fixed time interval following a click-to-close event. This pauses the timer indefinitely until the mouse leaves the toast. After the mouse leaves, a short timer is started so that transient mouseout events don't surprise the user. R=mukai@chromium.org TBR=dimich@chromium.org BUG=236674 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=197956

Patch Set 1 #

Patch Set 2 : name constant #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+44 lines, -19 lines)			Patch
M	ui/message_center/views/message_popup_collection.h	View		2 chunks	+8 lines, -2 lines	0 comments	Download
M	ui/message_center/views/message_popup_collection.cc	View	1	4 chunks	+33 lines, -14 lines	0 comments	Download
M	ui/message_center/views/toast_contents_view.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/14817004/2001

7 years, 7 months ago (2013-05-02 14:35:47 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_chromeos for step(s) ash_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=109827

7 years, 7 months ago (2013-05-02 15:41:22 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dewittj@chromium.org/14817004/2001

7 years, 7 months ago (2013-05-02 16:39:42 UTC) #5

Message was sent while issue was closed.

Change committed as 197956

Expand Messages | Collapse Messages