net/quic/quic_crypto_stream_test.cc - Issue 14816006: Land Recent QUIC changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/quic_crypto_stream_test.cc

Issue 14816006: Land Recent QUIC changes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Added missing NET_PRIVATE_EXPORT to QuicWallTime Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/quic_crypto_stream_test.cc

diff --git a/net/quic/quic_crypto_stream_test.cc b/net/quic/quic_crypto_stream_test.cc

index 6e465ab396acdf9243a700d7d94509c5377b6ba6..cc69304b7492a50a2620dde4898721f4438d53b4 100644

--- a/net/quic/quic_crypto_stream_test.cc

+++ b/net/quic/quic_crypto_stream_test.cc

@@ -98,7 +98,11 @@ TEST_F(QuicCryptoStreamTest, ProcessData) {

TEST_F(QuicCryptoStreamTest, ProcessBadData) {

string bad(message_data_->data(), message_data_->length());

- bad[8] = 0x7F; // out of order tag

+ const int kFirstTagIndex = sizeof(uint32) + // message tag

+ sizeof(uint16) + // number of tag-value pairs

+ sizeof(uint16); // padding

+ EXPECT_EQ(1, bad[kFirstTagIndex]);

+ bad[kFirstTagIndex] = 0x7F; // out of order tag

EXPECT_CALL(*connection_,

SendConnectionClose(QUIC_CRYPTO_TAGS_OUT_OF_ORDER));

« no previous file with comments | « net/quic/quic_crypto_stream.cc ('k') | net/quic/quic_framer.h » ('j') | no next file with comments »