Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: Tools/Scripts/webkitpy/layout_tests/models/test_failures.py

Issue 148153009: DOM-object leak detection at run_webkit_tests.py (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Bug fix: unit test Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/layout_tests/models/test_failures.py
diff --git a/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py b/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py
index caed9204bd72e117e2a207f89a065b23df1064de..87cd1df723a522bfb23c6c28f8daccb96aa74070 100644
--- a/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py
+++ b/Tools/Scripts/webkitpy/layout_tests/models/test_failures.py
@@ -51,6 +51,8 @@ def determine_result_type(failure_list):
failure_types = [type(f) for f in failure_list]
if FailureCrash in failure_types:
return test_expectations.CRASH
+ elif FailureLeak in failure_types:
+ return test_expectations.LEAK
elif FailureTimeout in failure_types:
return test_expectations.TIMEOUT
elif FailureEarlyExit in failure_types:
@@ -137,6 +139,16 @@ class FailureCrash(TestFailure):
return True
+class FailureLeak(TestFailure):
+ def __init__(self, is_reftest=False, log=''):
+ super(FailureLeak, self).__init__()
+ self.is_reftest = is_reftest
+ self.log = log
+
+ def message(self):
+ return "leak detected: %s" % (self.log)
+
+
class FailureMissingResult(TestFailure):
def message(self):
return "-expected.txt was missing"

Powered by Google App Engine
This is Rietveld 408576698