Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h

Issue 148143004: Add notification mechanism when BrowserActionButton's icon has been updated. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h
diff --git a/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h b/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h
index 15964e499672c793f2e7e5fb6a287e83cefabc33..c63867a5e5b0d6d3b7cdfc433f9ab037846b2b8f 100644
--- a/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h
+++ b/chrome/browser/ui/views/extensions/browser_action_overflow_menu_controller.h
@@ -17,6 +17,8 @@ class Browser;
class BrowserActionsContainer;
class BrowserActionView;
+class IconUpdater;
+
namespace views {
class MenuRunner;
class Widget;
@@ -115,6 +117,10 @@ class BrowserActionOverflowMenuController : public views::MenuDelegate {
// Whether this controller is being used for drop.
bool for_drop_;
+ // The vector keeps all icon updaters, and deletes them when the controller
+ // is being destructed
Finnur 2014/02/19 11:46:31 s/destructed/destroyed./ Note the period in the e
+ std::vector<IconUpdater*> icon_updaters_;
+
friend class base::DeleteHelper<BrowserActionOverflowMenuController>;
DISALLOW_COPY_AND_ASSIGN(BrowserActionOverflowMenuController);

Powered by Google App Engine
This is Rietveld 408576698