Add notification mechanism when BrowserActionButton's icon has been updated.

ui/views/controls/menu/menu_item_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/menu/menu_item_view.h"
 
 #include "base/i18n/case_conversion.h"
 #include "base/stl_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "grit/ui_resources.h"
@@ skipping 70 matching lines @@
 
 // static
 int MenuItemView::item_right_margin_;
 
 // static
 int MenuItemView::pref_menu_height_;
 
 // static
 const char MenuItemView::kViewClassName[] = "MenuItemView";
 
+// Note: This class also has a protected constructor and a common Init function
+// to initialize both.
 MenuItemView::MenuItemView(MenuDelegate* delegate)
     : delegate_(delegate),
       controller_(NULL),
       canceled_(false),
       parent_menu_item_(NULL),
       type_(SUBMENU),
       selected_(false),
       command_(0),
       submenu_(NULL),
       has_mnemonics_(false),
@@ skipping 451 matching lines @@
   invalidate_dimensions();
 }
 
 const MenuConfig& MenuItemView::GetMenuConfig() const {
   const MenuController* controller = GetMenuController();
   if (controller)
     return controller->menu_config_;
   return MenuConfig::instance(NULL);
 }
 
+// Note: This class also has a public constructor and a common Init function

[sky, 2014/02/19 15:01:19]

These comments aren't helpful, nuke them.

+// to initialize both.
 MenuItemView::MenuItemView(MenuItemView* parent,
                            int command,
                            MenuItemView::Type type)
     : delegate_(NULL),
       controller_(NULL),
       canceled_(false),
       parent_menu_item_(parent),
       type_(type),
       selected_(false),
       command_(command),
@@ skipping 488 matching lines @@
     } else {
       const Type& type = menu_item->GetType();
       if (type == CHECKBOX || type == RADIO)
         return true;
     }
   }
   return false;
 }
 
 }  // namespace views