Retire the Enterprise Web Store policies.

Retire the Enterprise Web Store policies.

EnterpriseWebStoreName and EnterpriseWebStoreURL were an attempt at
supporting organization-specific app collections. There are now better
ways to do this that don't require invasive Chrome changes, so retire
the two policies.

BUG=chromium:178938, chromium:240648
TEST=Still compiles and passes tests.
TBR=jochen@chromium.org, estade@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202579

[Joao da Silva, 2013-05-16 08:27:34]

lgtm

https://codereview.chromium.org/14813039/diff/1/chrome/browser/extensions/com...
File chrome/browser/extensions/component_loader.cc (right):

https://codereview.chromium.org/14813039/diff/1/chrome/browser/extensions/com...
chrome/browser/extensions/component_loader.cc:12: #include
"base/prefs/pref_notifier.h"
nit: these 2 are not used

https://codereview.chromium.org/14813039/diff/1/chrome/browser/extensions/com...
chrome/browser/extensions/component_loader.cc:23: #include
"components/user_prefs/pref_registry_syncable.h"
nit: not used

https://codereview.chromium.org/14813039/diff/1/chrome/browser/extensions/com...
File chrome/browser/extensions/component_loader.h (right):

https://codereview.chromium.org/14813039/diff/1/chrome/browser/extensions/com...
chrome/browser/extensions/component_loader.h:19: class PrefRegistrySyncable;
nit: not used

[Mattias Nissler (ping if slow), 2013-05-16 12:08:21]

https://codereview.chromium.org/14813039/diff/1/chrome/browser/extensions/com...
File chrome/browser/extensions/component_loader.cc (right):

https://codereview.chromium.org/14813039/diff/1/chrome/browser/extensions/com...
chrome/browser/extensions/component_loader.cc:12: #include
"base/prefs/pref_notifier.h"
On 2013/05/16 08:27:35, Joao da Silva wrote:
> nit: these 2 are not used

Done.

https://codereview.chromium.org/14813039/diff/1/chrome/browser/extensions/com...
chrome/browser/extensions/component_loader.cc:23: #include
"components/user_prefs/pref_registry_syncable.h"
On 2013/05/16 08:27:35, Joao da Silva wrote:
> nit: not used

Done.

https://codereview.chromium.org/14813039/diff/1/chrome/browser/extensions/com...
File chrome/browser/extensions/component_loader.h (right):

https://codereview.chromium.org/14813039/diff/1/chrome/browser/extensions/com...
chrome/browser/extensions/component_loader.h:19: class PrefRegistrySyncable;
On 2013/05/16 08:27:35, Joao da Silva wrote:
> nit: not used

Done.

[commit-bot: I haz the power, 2013-05-16 12:09:03]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnissler@chromium.org/14813039/10001

[commit-bot: I haz the power, 2013-05-16 12:20:46]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Mattias Nissler (ping if slow), 2013-05-16 14:08:57]

+jyasskin for chrome/browser/extensions/OWNERShip.

[Jeffrey Yasskin, 2013-05-16 16:59:36]

Woot! I don't see any ways that removing this could break existing user code. As
mentioned below, I'd like to make sure that the old pref won't stick around in
user files, but that might be unnecessary given how the pref is created. If it's
unnecessary, lgtm.

https://codereview.chromium.org/14813039/diff/10001/chrome/browser/extensions...
File chrome/browser/extensions/component_loader.cc (left):

https://codereview.chromium.org/14813039/diff/10001/chrome/browser/extensions...
chrome/browser/extensions/component_loader.cc:492:
prefs::kEnterpriseWebStoreURL,
Now that we're not using these prefs anymore, could you add temporary code to
remove them from the users' prefs files? I'd kinda expect that to already exist
somewhere, but I don't know where it would be.

Or does the fact that the pref was added by policy mean that it'll automatically
get removed when enterprises stop adding it through policy?

[Mattias Nissler (ping if slow), 2013-05-17 09:38:17]

https://codereview.chromium.org/14813039/diff/10001/chrome/browser/extensions...
File chrome/browser/extensions/component_loader.cc (left):

https://codereview.chromium.org/14813039/diff/10001/chrome/browser/extensions...
chrome/browser/extensions/component_loader.cc:492:
prefs::kEnterpriseWebStoreURL,
On 2013/05/16 16:59:36, Jeffrey Yasskin wrote:
> Now that we're not using these prefs anymore, could you add temporary code to
> remove them from the users' prefs files? I'd kinda expect that to already
exist
> somewhere, but I don't know where it would be.
> 
> Or does the fact that the pref was added by policy mean that it'll
automatically
> get removed when enterprises stop adding it through policy?

Good point actually. The rule we're generally following is this: Cleanup is
advised if Chrome could have dumped a value for the pref into the user's pref
file. If Chrome has never had code to write the pref, we deem cleanup
unnecessary.

In this case the pref has only ever been used as a vehicle to deliver the
policy, so we're good without cleanup code.

[commit-bot: I haz the power, 2013-05-17 09:39:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnissler@chromium.org/14813039/10001

[commit-bot: I haz the power, 2013-05-17 09:50:40]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[Mattias Nissler (ping if slow), 2013-05-17 11:40:30]

+ jochen@ and estade@ to TBR for the resource removals.

+ bartfab@ for the inline question

https://codereview.chromium.org/14813039/diff/10001/chrome/browser/ui/webui/o...
File chrome/browser/ui/webui/options/preferences_browsertest.cc (left):

https://codereview.chromium.org/14813039/diff/10001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/preferences_browsertest.cc:439: // String pref.
Bartosz, can you tell me what's the right thing to do here? I can't find other
cross-platform URL and string policies to put here.

[bartfab (slow), 2013-05-17 12:59:08]

https://codereview.chromium.org/14813039/diff/10001/chrome/browser/ui/webui/o...
File chrome/browser/ui/webui/options/preferences_browsertest.cc (left):

https://codereview.chromium.org/14813039/diff/10001/chrome/browser/ui/webui/o...
chrome/browser/ui/webui/options/preferences_browsertest.cc:439: // String pref.
On 2013/05/17 11:40:30, Mattias Nissler wrote:
> Bartosz, can you tell me what's the right thing to do here? I can't find other
> cross-platform URL and string policies to put here.

How about HomepageLocation? This is a cross-platform URL pref. IIRC, you can
always set the value of a URL pref as if it was a string pref as well. So it
should be OK to use it for both purposes.

[jochen (gone - plz use gerrit), 2013-05-21 07:36:57]

deleting code lgtm

[commit-bot: I haz the power, 2013-05-28 14:18:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mnissler@chromium.org/14813039/41001

[commit-bot: I haz the power, 2013-05-28 16:32:20]

Change committed as 202579