Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 14813033: Don't forget to call RemoveObserver when TtsDispatcher is destroyed. (Closed)

Created:
7 years, 7 months ago by dmazzoni
Modified:
7 years, 7 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Visibility:
Public.

Description

Don't forget to call RemoveObserver when TtsDispatcher is destroyed. BUG=171887 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200371

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/renderer/tts_dispatcher.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dmazzoni
7 years, 7 months ago (2013-05-14 20:26:29 UTC) #1
Lei Zhang
lgtm
7 years, 7 months ago (2013-05-14 20:39:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/14813033/1
7 years, 7 months ago (2013-05-14 20:42:09 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=148559
7 years, 7 months ago (2013-05-15 00:48:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/14813033/1
7 years, 7 months ago (2013-05-15 19:07:58 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-15 22:29:41 UTC) #6
Message was sent while issue was closed.
Change committed as 200371

Powered by Google App Engine
This is Rietveld 408576698