Refactor viewport initialization logic out of WebViewImpl.

Source/core/page/Settings.h

 /*
  * Copyright (C) 2003, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All rights reserved.
  *           (C) 2006 Graham Dennis (graham.dennis@gmail.com)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 79 matching lines @@
     void setTextAutosizingEnabled(bool);
     bool textAutosizingEnabled() const { return m_textAutosizingEnabled; }
 
     void setTextAutosizingFontScaleFactor(float);
     float textAutosizingFontScaleFactor() const { return m_textAutosizingFontScaleFactor; }
 
     // Only set by Layout Tests, and only used if textAutosizingEnabled() returns true.
     void setTextAutosizingWindowSizeOverride(const IntSize&);
     const IntSize& textAutosizingWindowSizeOverride() const { return m_textAutosizingWindowSizeOverride; }
 
+    void setUseWideViewport(bool);
+    bool useWideViewport() const { return m_useWideViewport; }
+
+    void setLoadWithOverviewMode(bool);
+    bool loadWithOverviewMode() const { return m_loadWithOverviewMode; }
+
     // Only set by Layout Tests.
     void setMediaTypeOverride(const String&);
     const String& mediaTypeOverride() const { return m_mediaTypeOverride; }
 
     // Unlike areImagesEnabled, this only suppresses the network load of
     // the image URL.  A cached image will still be rendered if requested.
     void setLoadsImagesAutomatically(bool);
     bool loadsImagesAutomatically() const { return m_loadsImagesAutomatically; }
 
     // Clients that execute script should call ScriptController::canExecuteScripts()
@@ skipping 55 matching lines @@
     ScriptFontFamilyMap m_standardFontFamilyMap;
     ScriptFontFamilyMap m_serifFontFamilyMap;
     ScriptFontFamilyMap m_fixedFontFamilyMap;
     ScriptFontFamilyMap m_sansSerifFontFamilyMap;
     ScriptFontFamilyMap m_cursiveFontFamilyMap;
     ScriptFontFamilyMap m_fantasyFontFamilyMap;
     ScriptFontFamilyMap m_pictographFontFamilyMap;
     float m_textAutosizingFontScaleFactor;
     IntSize m_textAutosizingWindowSizeOverride;
     bool m_textAutosizingEnabled : 1;
+    bool m_useWideViewport : 1;

[mnaganov (inactive), 2013/05/24 09:26:38]

You should also add them into Settings.in to get them properly initialized.

[mnaganov (inactive), 2013/05/24 09:29:26]

Ah, sorry. In your case, you should list them in the Settings constructor.

+    bool m_loadWithOverviewMode : 1;
 
     SETTINGS_MEMBER_VARIABLES
 
     bool m_isJavaEnabled : 1;
     bool m_loadsImagesAutomatically : 1;
     bool m_areImagesEnabled : 1;
     bool m_arePluginsEnabled : 1;
     bool m_isScriptEnabled : 1;
     unsigned m_fontRenderingMode : 1;
     bool m_isCSSCustomFilterEnabled : 1;
     bool m_cssStickyPositionEnabled : 1;
     bool m_cssVariablesEnabled : 1;
     bool m_dnsPrefetchingEnabled : 1;
 
     bool m_touchEventEmulationEnabled : 1;
     bool m_openGLMultisamplingEnabled : 1;
 
     Timer<Settings> m_setImageLoadingSettingsTimer;
     void imageLoadingSettingsTimerFired(Timer<Settings>*);
 
     static bool gMockScrollbarsEnabled;
     static bool gUsesOverlayScrollbars;
 };
 
 } // namespace WebCore
 
 #endif // Settings_h