Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 14813022: Fix null dereference in GLES2Implementation::IsExtensionAvailable. (Closed)

Created:
7 years, 7 months ago by apatrick_chromium
Modified:
7 years, 7 months ago
Reviewers:
greggman
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Fix null dereference in GLES2Implementation::IsExtensionAvailable. glGetString (and GLES2Implementation::GetStringHelper) can return null on error, for example context lost. This makes IsExtensionAvailable always return false if there is an error. BUG=239572 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199423

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
apatrick_chromium
7 years, 7 months ago (2013-05-10 00:00:58 UTC) #1
greggman
lgtm
7 years, 7 months ago (2013-05-10 00:15:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apatrick@chromium.org/14813022/1
7 years, 7 months ago (2013-05-10 00:22:56 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-10 00:39:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apatrick@chromium.org/14813022/1
7 years, 7 months ago (2013-05-10 01:17:12 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-10 07:54:27 UTC) #6
Message was sent while issue was closed.
Change committed as 199423

Powered by Google App Engine
This is Rietveld 408576698