Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14805007: Clean up expectations for animation helper tests. (Closed)

Created:
7 years, 7 months ago by dstockwell
Modified:
7 years, 7 months ago
Reviewers:
Noel Gordon
CC:
blink-reviews, shans, dstockwell, Steve Block, eae+blinkwatch, darktears
Visibility:
Public.

Description

Clean up expectations for animation helper tests. * Warn about tests running in real time. * Always dump as text. * Only require result element for pixel/ref tests. BUG=235752 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149946

Patch Set 1 #

Patch Set 2 : Rebaseline results outside LayoutTests/animations #

Patch Set 3 : Fix css3/filters/composited-during-animation.html #

Patch Set 4 : Rebaseline LayoutTests/css3/masking/clip-path-animation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -243 lines) Patch
M LayoutTests/animations/3d/matrix-transform-type-animation-expected.txt View 1 chunk +2 lines, -15 lines 0 comments Download
M LayoutTests/animations/animation-border-overflow-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/animation-delay-changed-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/animations/animation-direction-normal-expected.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/animations/animation-direction-reverse-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/animations/animation-direction-reverse-hardware-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/animations/animation-direction-reverse-hardware-opacity-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/animations/animation-direction-reverse-non-hardware-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
M LayoutTests/animations/animation-direction-reverse-timing-functions-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/animations/animation-direction-reverse-timing-functions-hardware-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/animations/big-rotation-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/animations/change-keyframes-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/animations/change-keyframes-name-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/animations/change-one-anim-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/animations/combo-transform-rotate+scale-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/cross-fade-border-image-source-expected.txt View 1 chunk +4 lines, -21 lines 0 comments Download
M LayoutTests/animations/duplicated-keyframes-name-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/dynamic-stylesheet-loading-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/animations/generic-from-to-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/import-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/keyframe-timing-functions-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/keyframe-timing-functions-transform-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/keyframe-timing-functions2-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/keyframes-comma-separated-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/keyframes-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/keyframes-invalid-keys-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/keyframes-out-of-order-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/lineheight-animation-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/longhand-timing-function-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/animations/matrix-anim-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/missing-from-to-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/missing-from-to-transforms-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/multiple-animations-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/multiple-keyframes-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/play-state-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/animations/play-state-paused-expected.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/animations/play-state-suspend-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/animations/resources/animation-test-helpers.js View 4 chunks +9 lines, -3 lines 0 comments Download
M LayoutTests/animations/simultaneous-start-left-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/simultaneous-start-transform-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/animations/stop-animation-on-suspend-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/animations/suspend-resume-animation-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/animations/timing-functions-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/animations/transition-and-animation-1-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/animations/transition-and-animation-2-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/animations/transition-and-animation-3-expected.txt View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/animations/unanimated-style-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/animations/width-using-ems-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/compositing/reflections/animation-inside-reflection-expected.txt View 1 1 chunk +4 lines, -18 lines 0 comments Download
M LayoutTests/compositing/reflections/nested-reflection-animated-expected.txt View 1 1 chunk +5 lines, -18 lines 0 comments Download
M LayoutTests/css3/filters/composited-during-animation.html View 1 2 2 chunks +2 lines, -5 lines 0 comments Download
M LayoutTests/css3/filters/composited-during-animation-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/css3/filters/custom/custom-filter-animation-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/css3/filters/custom/custom-filter-array-blending-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/css3/filters/custom/custom-filter-transforms-animation-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/css3/filters/filter-animation-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/css3/filters/filter-animation-from-none-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/css3/filters/filter-animation-from-none-hw-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/css3/filters/filter-animation-from-none-multi-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/css3/filters/filter-animation-from-none-multi-hw-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/css3/filters/filter-animation-hw-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/css3/filters/filter-animation-multi-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/css3/filters/filter-animation-multi-hw-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/css3/masking/clip-path-animation-expected.txt View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/exclusions/shape-inside/shape-inside-animation-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/platform/chromium-win/animations/3d/matrix-transform-type-animation-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/platform/chromium-win/animations/cross-fade-border-image-source-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/platform/chromium-win/compositing/reflections/animation-inside-reflection-expected.txt View 1 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/platform/chromium-win/compositing/reflections/nested-reflection-animated-expected.txt View 1 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dstockwell
7 years, 7 months ago (2013-05-08 04:07:09 UTC) #1
Noel Gordon
LGTM
7 years, 7 months ago (2013-05-08 04:17:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/14805007/1
7 years, 7 months ago (2013-05-08 04:23:32 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=7165
7 years, 7 months ago (2013-05-08 05:03:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/14805007/13002
7 years, 7 months ago (2013-05-08 06:56:14 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=7179
7 years, 7 months ago (2013-05-08 07:39:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dstockwell@chromium.org/14805007/33001
7 years, 7 months ago (2013-05-08 07:49:52 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-08 08:50:21 UTC) #8
Message was sent while issue was closed. 
Change committed as 149946

Powered by Google App Engine
This is Rietveld 408576698