Issue 14801011: Removed unused Document forward declaration+include from SecurityOrigin

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14801011: Removed unused Document forward declaration+include from SecurityOrigin (Closed)

Created:
7 years, 7 months ago by jamesr

Modified:
7 years, 7 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, eae+blinkwatch, michaeln

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Removed unused Document forward declaration+include from SecurityOrigin We use (Web)SecurityOrigin all over the place and need to be able to understand its dependencies. These appear unused. BUG=237267 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149980

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	Source/core/page/SecurityOrigin.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	Source/core/page/SecurityOrigin.cpp	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jamesr

I believe it's the case that SecurityOrigin is basically a string manipulation library, is that ...

7 years, 7 months ago (2013-05-08 20:50:56 UTC) #1

abarth-chromium

LGTM We can probably factor out the string manipulation parts. There are other parts that ...

7 years, 7 months ago (2013-05-08 20:54:34 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/14801011/1

7 years, 7 months ago (2013-05-08 21:23:16 UTC) #3

Message was sent while issue was closed.

Change committed as 149980

Expand Messages | Collapse Messages