Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 14801011: Removed unused Document forward declaration+include from SecurityOrigin (Closed)

Created:
7 years, 7 months ago by jamesr
Modified:
7 years, 7 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, eae+blinkwatch, michaeln
Visibility:
Public.

Description

Removed unused Document forward declaration+include from SecurityOrigin We use (Web)SecurityOrigin all over the place and need to be able to understand its dependencies. These appear unused. BUG=237267 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149980

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M Source/core/page/SecurityOrigin.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/page/SecurityOrigin.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jamesr
I believe it's the case that SecurityOrigin is basically a string manipulation library, is that ...
7 years, 7 months ago (2013-05-08 20:50:56 UTC) #1
abarth-chromium
LGTM We can probably factor out the string manipulation parts. There are other parts that ...
7 years, 7 months ago (2013-05-08 20:54:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/14801011/1
7 years, 7 months ago (2013-05-08 21:23:16 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-08 21:30:48 UTC) #4
Message was sent while issue was closed.
Change committed as 149980

Powered by Google App Engine
This is Rietveld 408576698