Cast: end2end bug fixes

Cast: end2end bug fixes

main changes:
- Updating synthetic video test sequence to be more uniform.
- Fixing added delay to render/playout times introduced in the rtp-stats API update.
- Sending audio packets to pacer in a timed manner.
 

BUG=329563
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250947

[mikhal1, 2014-02-12 21:08:54]

Please review,

-Mikhal

[pwestin, 2014-02-12 21:16:43]

https://chromiumcodereview.appspot.com/147993010/diff/170001/media/cast/test/...
File media/cast/test/end2end_unittest.cc (right):

https://chromiumcodereview.appspot.com/147993010/diff/170001/media/cast/test/...
media/cast/test/end2end_unittest.cc:66: static const int kTimerErrorMs = 20;
please add your findings to where these 20 ms originate from

https://chromiumcodereview.appspot.com/147993010/diff/170001/media/cast/test/...
media/cast/test/end2end_unittest.cc:1182: // aspects of the end2end, but is
basically equivalent to LoopNoLossPcm16.
weird sentence break

https://chromiumcodereview.appspot.com/147993010/diff/170001/media/cast/test/...
media/cast/test/end2end_unittest.cc:1254: // events
weird sentence break

https://chromiumcodereview.appspot.com/147993010/diff/170001/media/cast/test/...
media/cast/test/end2end_unittest.cc:1257: // CastEnvironment
weird sentence break

https://chromiumcodereview.appspot.com/147993010/diff/170001/media/cast/test/...
media/cast/test/end2end_unittest.cc:1262: // that
weird sentence break

https://chromiumcodereview.appspot.com/147993010/diff/170001/media/cast/trans...
File media/cast/transport/rtp_sender/rtp_sender.cc (right):

https://chromiumcodereview.appspot.com/147993010/diff/170001/media/cast/trans...
media/cast/transport/rtp_sender/rtp_sender.cc:17: // Schedule the RTP statistics
callback every 33mS.
explain why 33

[mikhal1, 2014-02-12 23:00:18]

Somehow this cl got all weird. Closing this and starting a new one.

[mikhal1, 2014-02-12 23:21:02]

And we're back!

PTAL

https://codereview.chromium.org/147993010/diff/170001/media/cast/test/end2end...
File media/cast/test/end2end_unittest.cc (right):

https://codereview.chromium.org/147993010/diff/170001/media/cast/test/end2end...
media/cast/test/end2end_unittest.cc:66: static const int kTimerErrorMs = 20;
On 2014/02/12 21:16:43, pwestin wrote:
> please add your findings to where these 20 ms originate from 

Done.

https://codereview.chromium.org/147993010/diff/170001/media/cast/test/end2end...
media/cast/test/end2end_unittest.cc:1182: // aspects of the end2end, but is
basically equivalent to LoopNoLossPcm16.
On 2014/02/12 21:16:43, pwestin wrote:
> weird sentence break

Done.

https://codereview.chromium.org/147993010/diff/170001/media/cast/test/end2end...
media/cast/test/end2end_unittest.cc:1254: // events
On 2014/02/12 21:16:43, pwestin wrote:
> weird sentence break

Done.

https://codereview.chromium.org/147993010/diff/170001/media/cast/test/end2end...
media/cast/test/end2end_unittest.cc:1257: // CastEnvironment
On 2014/02/12 21:16:43, pwestin wrote:
> weird sentence break

Done.

https://codereview.chromium.org/147993010/diff/170001/media/cast/test/end2end...
media/cast/test/end2end_unittest.cc:1262: // that
On 2014/02/12 21:16:43, pwestin wrote:
> weird sentence break

Done.

https://codereview.chromium.org/147993010/diff/170001/media/cast/transport/rt...
File media/cast/transport/rtp_sender/rtp_sender.cc (right):

https://codereview.chromium.org/147993010/diff/170001/media/cast/transport/rt...
media/cast/transport/rtp_sender/rtp_sender.cc:17: // Schedule the RTP statistics
callback every 33mS.
On 2014/02/12 21:16:43, pwestin wrote:
> explain why 33 

Done.

[pwestin, 2014-02-12 23:25:25]

lgtm with nit fixed

https://codereview.chromium.org/147993010/diff/380001/media/cast/test/end2end...
File media/cast/test/end2end_unittest.cc (right):

https://codereview.chromium.org/147993010/diff/380001/media/cast/test/end2end...
media/cast/test/end2end_unittest.cc:1066: // logging
nit remove line break

[mikhal1, 2014-02-12 23:31:32]

https://codereview.chromium.org/147993010/diff/380001/media/cast/test/end2end...
File media/cast/test/end2end_unittest.cc (right):

https://codereview.chromium.org/147993010/diff/380001/media/cast/test/end2end...
media/cast/test/end2end_unittest.cc:1066: // logging
On 2014/02/12 23:25:28, pwestin wrote:
> nit remove line break

Done.

[mikhal1, 2014-02-12 23:31:38]

The CQ bit was checked by mikhal@chromium.org

[commit-bot: I haz the power, 2014-02-12 23:32:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mikhal@chromium.org/147993010/460001

[commit-bot: I haz the power, 2014-02-13 00:01:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-13 00:01:06]

Retried try job too often on win_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[mikhal1, 2014-02-13 00:04:56]

The CQ bit was checked by mikhal@chromium.org

[commit-bot: I haz the power, 2014-02-13 00:05:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mikhal@chromium.org/147993010/460001

[commit-bot: I haz the power, 2014-02-13 04:36:02]

Change committed as 250947