Issue 14798003: Add nag_timer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14798003: Add nag_timer. (Closed)

Created:
7 years, 7 months ago by szager1

Modified:
7 years, 7 months ago

Reviewers:
cmp, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, Finnur

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Add nag_timer. BUG=227537 R=maruel@chromium.org,cmp@chromium.org NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=197790

Patch Set 2 : Switch to threading.Timer #

Total comments: 1

Patch Set 3 : Switch nag_timer default to None #

Patch Set 4 : Don't check inequality against None #

Patch Set 5 : 80 chars #

Created: 7 years, 7 months ago

		Unified diffs	Side-by-side diffs	Stats (+62 lines, -6 lines)
	M	subprocess2.py	View	9 chunks	+40 lines, -5 lines	0 comments
	M	tests/subprocess2_test.py	View	2 chunks	+22 lines, -1 line	0 comments

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

szager1

Please hold off; I noticed that this change causes the top-level process to hang on ...

7 years, 7 months ago (2013-05-01 23:54:33 UTC) #2

M-A Ruel

lgtm with nit https://codereview.chromium.org/14798003/diff/4001/subprocess2.py File subprocess2.py (right): https://codereview.chromium.org/14798003/diff/4001/subprocess2.py#newcode356 subprocess2.py:356: def communicate(self, input=None, timeout=None, nag_timer=0): I ...

7 years, 7 months ago (2013-05-02 00:34:19 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/14798003/14001

7 years, 7 months ago (2013-05-02 02:47:14 UTC) #5

Message was sent while issue was closed.

Change committed as 197790