Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 14797006: Files.app: Changed the item click behavior of auto complete list. (Closed)

Created:
7 years, 7 months ago by hirono
Modified:
7 years, 7 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Changed the item click behavior of auto complete list. Originally, when the item of auto complete list is clicked, the default task of selected item is executed. This CL handles the cases of other dialog types except FULL_PAGE. In this cases, when the item of auto complete list is clicked, the file manager should be closed like that its OK button is clicked. BUG=237549 TEST=Open file manager as a modal dialog (by Ctrl+O, Ctrl + S), search drive items by using auto complete list and click a result item Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198700

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed a comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/browser/resources/file_manager/js/file_manager.js View 1 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
hirono
Yoshiki-san, Please check this CL? Thank you!
7 years, 7 months ago (2013-05-07 02:21:28 UTC) #1
yoshiki
lgtm with nit https://codereview.chromium.org/14797006/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://codereview.chromium.org/14797006/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode3417 chrome/browser/resources/file_manager/js/file_manager.js:3417: } nit: add a semicolon at ...
7 years, 7 months ago (2013-05-07 02:30:01 UTC) #2
hirono
Thank you very much! https://codereview.chromium.org/14797006/diff/1/chrome/browser/resources/file_manager/js/file_manager.js File chrome/browser/resources/file_manager/js/file_manager.js (right): https://codereview.chromium.org/14797006/diff/1/chrome/browser/resources/file_manager/js/file_manager.js#newcode3417 chrome/browser/resources/file_manager/js/file_manager.js:3417: } On 2013/05/07 02:30:01, yoshiki ...
7 years, 7 months ago (2013-05-07 03:20:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/14797006/7001
7 years, 7 months ago (2013-05-07 03:21:06 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-05-07 12:54:35 UTC) #5
Message was sent while issue was closed.
Change committed as 198700

Powered by Google App Engine
This is Rietveld 408576698