Cleanup: Deprecate FileSystemCallbackDispatcher

webkit/fileapi/file_system_callback_dispatcher.h

-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef WEBKIT_FILEAPI_FILE_SYSTEM_CALLBACK_DISPATCHER_H_
-#define WEBKIT_FILEAPI_FILE_SYSTEM_CALLBACK_DISPATCHER_H_
-
-#include <string>
-#include <vector>
-
-#include "base/files/file_util_proxy.h"
-#include "base/platform_file.h"
-#include "base/process.h"
-#include "webkit/quota/quota_types.h"
-#include "webkit/storage/webkit_storage_export.h"
-
-class GURL;
-
-namespace fileapi {
-
-// This class mirrors the callbacks in
-// third_party/WebKit/Source/WebKit/chromium/public/WebFileSystemCallbacks.h,
-// but uses chromium types.

[michaeln, 2013/05/14 22:18:58]

The code looks correct and all but I don't really see the need for the change.

I think i'm less enthusiastic about this change because i think it loses some
clarity. The old way, the relationship between this chromium interface, the set
of ipc messages, and the WebKit interface, and the internal WebCore interface,
and the IDL defined scriptable interface... are pretty clear given how similar
those all are. Now there's a layer of 'closure' indirection that obscures that
self similarity. The previous comments demonstrate that sort of loss of clarity.

[kinuko, 2013/05/15 13:58:03]

In the new patch one callback in Blink/WebKit is always mapped to one
base::Callback, so it should be adding no extra layers.

(If we keep this class anyone who wants to send FileSystem IPC needs to
implement this... which feels unfortunate to me and I felt this patch is 'win'
at least in pepper code)

-class WEBKIT_STORAGE_EXPORT FileSystemCallbackDispatcher {
- public:
-  virtual ~FileSystemCallbackDispatcher();
-
-  // Callback for various operations that don't require return values.
-  virtual void DidSucceed() = 0;
-
-  // Callback to report information for a file.
-  virtual void DidReadMetadata(
-      const base::PlatformFileInfo& file_info,
-      const base::FilePath& platform_path) = 0;
-
-  // Callback to report information for a file and its actual file path.
-  virtual void DidCreateSnapshotFile(
-      const base::PlatformFileInfo& file_info,
-      const base::FilePath& platform_path) = 0;
-
-  // Callback to report the contents of a directory. If the contents of
-  // the given directory are reported in one batch, then |entries| will have
-  // the list of all files/directories in the given directory, |has_more| will
-  // be false, and this callback will be called only once. If the contents of
-  // the given directory are reported in multiple chunks, then this callback
-  // will be called multiple times, |entries| will have only a subset of
-  // all contents (the subsets reported in any two calls are disjoint), and
-  // |has_more| will be true, except for the last chunk.
-  virtual void DidReadDirectory(
-      const std::vector<base::FileUtilProxy::Entry>& entries,
-      bool has_more) = 0;
-
-  // Callback for opening a file system. Called with a name and root path for
-  // the FileSystem when the request is accepted. Used by WebFileSystem API.
-  virtual void DidOpenFileSystem(const std::string& name,
-                                 const GURL& root) = 0;
-
-  // Called with an error code when a requested operation has failed.
-  virtual void DidFail(base::PlatformFileError error_code) = 0;
-
-  // Callback for FileWriter's write() call.
-  virtual void DidWrite(int64 bytes, bool complete) = 0;
-
-  // Callback for OpenFile.  This isn't in WebFileSystemCallbacks, as it's just
-  // for Pepper.
-  // The method will be responsible for closing |file|.
-  virtual void DidOpenFile(base::PlatformFile file,
-                           int file_open_id,
-                           quota::QuotaLimitType quota_policy);
-};
-
-}  // namespace fileapi
-
-#endif  // WEBKIT_FILEAPI_FILE_SYSTEM_CALLBACK_DISPATCHER_H_