Local Rietveld TryServer testing

PRESUBMIT.py

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Top-level presubmit script for Blink.
 
 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
 for more details about the presubmit API built into gcl.
 """
 
+import sys
+
 
 _EXCLUDED_PATHS = ()
 
 
 def _CheckForVersionControlConflictsInFile(input_api, f):
     pattern = input_api.re.compile('^(?:<<<<<<<|>>>>>>>) |^=======$')
     errors = []
     for line_num, line in f.ChangedContents():
         if pattern.match(line):
             errors.append('    %s:%d %s' % (f.LocalPath(), line_num, line))
@@ skipping 18 matching lines @@
     # We should figure out what license checks we actually want to use.
     license_header = r'.*'
 
     results = []
     results.extend(input_api.canned_checks.PanProjectChecks(
         input_api, output_api, excluded_paths=_EXCLUDED_PATHS,
         maxlen=800, license_header=license_header))
     results.extend(_CheckForVersionControlConflicts(input_api, output_api))
     results.extend(_CheckPatchFiles(input_api, output_api))
     results.extend(_CheckTestExpectations(input_api, output_api))
+    results.extend(_CheckUnwantedDependencies(input_api, output_api))
     return results
 
 
 def _CheckSubversionConfig(input_api, output_api):
   """Verifies the subversion config file is correctly setup.
 
   Checks that autoprops are enabled, returns an error otherwise.
   """
   join = input_api.os_path.join
   if input_api.platform == 'win32':
@@ skipping 76 matching lines @@
         if child.returncode != 0:
             results.append(output_api.PresubmitError(
                 'check-webkit-style failed', [stderrdata]))
     except Exception as e:
         results.append(output_api.PresubmitNotifyResult(
             'Could not run check-webkit-style', [str(e)]))
 
     return results
 
 
+def _CheckUnwantedDependencies(input_api, output_api):
+    """Runs checkdeps on #include statements added in this
+    change. Breaking - rules is an error, breaking ! rules is a
+    warning.
+    """
+    # We need to wait until we have an input_api object and use this
+    # roundabout construct to import checkdeps because this file is
+    # eval-ed and thus doesn't have __file__.
+    original_sys_path = sys.path
+    try:
+        sys.path = sys.path + [input_api.os_path.realpath(input_api.os_path.join(
+                input_api.PresubmitLocalPath(), '..', '..', 'tools', 'checkdeps'))]
+        import checkdeps
+        from cpp_checker import CppChecker
+        from rules import Rule
+    finally:
+        # Restore sys.path to what it was before.
+        sys.path = original_sys_path
+
+    added_includes = []
+    for f in input_api.AffectedFiles():
+        if not CppChecker.IsCppFile(f.LocalPath()):
+            continue
+
+        changed_lines = [line for line_num, line in f.ChangedContents()]
+        added_includes.append([f.LocalPath(), changed_lines])
+
+    deps_checker = checkdeps.DepsChecker(input_api.PresubmitLocalPath())
+
+    error_descriptions = []
+    warning_descriptions = []
+    for path, rule_type, rule_description in deps_checker.CheckAddedCppIncludes(
+            added_includes):
+        description_with_path = '%s\n    %s' % (path, rule_description)
+        if rule_type == Rule.DISALLOW:
+            error_descriptions.append(description_with_path)
+        else:
+            warning_descriptions.append(description_with_path)
+
+    results = []
+    if error_descriptions:
+        results.append(output_api.PresubmitError(
+                'You added one or more #includes that violate checkdeps rules.',
+                error_descriptions))
+    if warning_descriptions:
+        results.append(output_api.PresubmitPromptOrNotify(
+                'You added one or more #includes of files that are temporarily\n'
+                'allowed but being removed. Can you avoid introducing the\n'
+                '#include? See relevant DEPS file(s) for details and contacts.',
+                warning_descriptions))
+    return results
+
+
 def CheckChangeOnUpload(input_api, output_api):
     results = []
     results.extend(_CommonChecks(input_api, output_api))
     results.extend(_CheckStyle(input_api, output_api))
     return results
 
 
 def CheckChangeOnCommit(input_api, output_api):
     results = []
     results.extend(_CommonChecks(input_api, output_api))
     results.extend(input_api.canned_checks.CheckTreeIsOpen(
         input_api, output_api,
         json_url='http://blink-status.appspot.com/current?format=json'))
     results.extend(input_api.canned_checks.CheckChangeHasDescription(
         input_api, output_api))
     results.extend(_CheckSubversionConfig(input_api, output_api))
     return results
 
 def GetPreferredTrySlaves(project, change):
     return ['linux_layout_rel', 'mac_layout_rel', 'win_layout_rel']