Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 14793009: Do not change environment between simulate and scope with no observable side-effects in HandlePrope… (Closed)

Created:
7 years, 7 months ago by ulan
Modified:
7 years, 7 months ago
Reviewers:
danno
CC:
v8-dev
Visibility:
Public.

Description

Do not change environment between simulate and scope with no observable side-effects in HandlePropertyAssignment. LChunkBuilder reconstructs the environment by applying simulates. A scope with no observable side-effects has no simulates. If the scope deoptimizes, then LChunkBuilder would miss the changes to the environment between the last simulate and the scope. R=danno@chromium.org BUG=v8:2671 TEST=mjsunit/regress/regress-2671.js Committed: https://code.google.com/p/v8/source/detail?r=14584

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M src/hydrogen.cc View 1 chunk +4 lines, -3 lines 0 comments Download
A + test/mjsunit/regress/regress-2671.js View 1 chunk +11 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL. I will add verification of environment in a separate CL.
7 years, 7 months ago (2013-05-07 16:02:32 UTC) #1
danno
lgtm
7 years, 7 months ago (2013-05-07 16:53:33 UTC) #2
ulan
7 years, 7 months ago (2013-05-08 07:40:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14584 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698