Split ExtensionSystem interface from ExtensionSystemImpl implementation, part 1.

extensions/browser/extension_system.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef EXTENSIONS_BROWSER_EXTENSION_SYSTEM_H_
+#define EXTENSIONS_BROWSER_EXTENSION_SYSTEM_H_
+
+#include <string>
+
+#include "base/memory/ref_counted.h"
+#include "base/memory/scoped_ptr.h"

[James Cook, 2014/01/28 23:40:57]

do you need this header?

[Yoyo Zhou, 2014/01/29 00:42:56]

Nope.

+#include "components/browser_context_keyed_service/browser_context_keyed_service.h"
+#include "extensions/common/extension.h"
+#include "extensions/common/one_shot_event.h"

[James Cook, 2014/01/28 23:40:57]

I don't think you need this header, probably can forward declare it

[Yoyo Zhou, 2014/01/29 00:42:56]

Done.

+
+class ExtensionService;
+class Profile;

[James Cook, 2014/01/28 23:40:57]

don't think you need this

[Yoyo Zhou, 2014/01/29 00:42:56]

Done.

+
+#if defined(OS_CHROMEOS)
+namespace chromeos {
+class DeviceLocalAccountManagementPolicyProvider;
+}
+#endif  // defined(OS_CHROMEOS)
+
+namespace content {
+class BrowserContext;
+}
+
+namespace extensions {
+
+class Blacklist;
+class ErrorConsole;
+class EventRouter;
+class Extension;
+class ExtensionSystemSharedFactory;
+class ExtensionWarningBadgeService;
+class ExtensionWarningService;
+class InfoMap;
+class InstallVerifier;
+class LazyBackgroundTaskQueue;
+class ManagementPolicy;
+class NavigationObserver;
+class ProcessManager;
+class RuntimeData;
+class StandardManagementPolicyProvider;
+class StateStore;
+class UserScriptMaster;
+// This interface supports using TestExtensionSystem for TestingProfiles

[James Cook, 2014/01/28 23:40:57]

comment nit: Blank line above. Also, it would be nice if this comment described
what ExtensionSystem is.

[Yoyo Zhou, 2014/01/29 00:42:56]

Added a comment.

+// that don't want all of the extensions baggage in their tests.
+class ExtensionSystem : public BrowserContextKeyedService {
+ public:
+  ExtensionSystem();
+  virtual ~ExtensionSystem();
+
+  // Returns the instance for the given browser context, or NULL if none.
+  // A convenience wrapper around ExtensionSystemFactory::GetForBrowserContext.
+  static ExtensionSystem* Get(content::BrowserContext* context);

[James Cook, 2014/01/28 23:40:57]

Hooray, one Get() method to rule them all!

+
+  // BrowserContextKeyedService implementation.
+  virtual void Shutdown() OVERRIDE {}

[James Cook, 2014/01/28 23:40:57]

optional nit: Maybe just not override it, since the default implementation is
{}?

[Yoyo Zhou, 2014/01/29 00:42:56]

Done.

+
+  // Initializes extensions machinery.
+  // Component extensions are always enabled, external and user extensions are
+  // controlled by |extensions_enabled|.
+  virtual void InitForRegularProfile(bool extensions_enabled) = 0;
+
+  // The ExtensionService is created at startup.
+  virtual ExtensionService* extension_service() = 0;
+
+  // Per-extension data that can change during the life of the process but
+  // does not persist across restarts. Lives on UI thread. Created at startup.
+  virtual RuntimeData* runtime_data() = 0;
+
+  // The class controlling whether users are permitted to perform certain
+  // actions on extensions (install, uninstall, disable, etc.).
+  // The ManagementPolicy is created at startup.
+  virtual ManagementPolicy* management_policy() = 0;
+
+  // The UserScriptMaster is created at startup.
+  virtual UserScriptMaster* user_script_master() = 0;
+
+  // The ProcessManager is created at startup.
+  virtual ProcessManager* process_manager() = 0;
+
+  // The StateStore is created at startup.
+  virtual StateStore* state_store() = 0;
+
+  // The rules store is created at startup.
+  virtual StateStore* rules_store() = 0;
+
+  // Returns the IO-thread-accessible extension data.
+  virtual InfoMap* info_map() = 0;
+
+  // The LazyBackgroundTaskQueue is created at startup.
+  virtual LazyBackgroundTaskQueue* lazy_background_task_queue() = 0;
+
+  // The EventRouter is created at startup.
+  virtual EventRouter* event_router() = 0;
+
+  // The ExtensionWarningService is created at startup.
+  virtual ExtensionWarningService* warning_service() = 0;
+
+  // The blacklist is created at startup.
+  virtual Blacklist* blacklist() = 0;
+
+  // The ErrorConsole is created at startup.
+  virtual ErrorConsole* error_console() = 0;
+
+  // The InstallVerifier is created at startup.
+  virtual InstallVerifier* install_verifier() = 0;
+
+  // Called by the ExtensionService that lives in this system. Gives the
+  // info map a chance to react to the load event before the EXTENSION_LOADED
+  // notification has fired. The purpose for handling this event first is to
+  // avoid race conditions by making sure URLRequestContexts learn about new
+  // extensions before anything else needs them to know.
+  virtual void RegisterExtensionWithRequestContexts(
+      const Extension* extension) {}
+
+  // Called by the ExtensionService that lives in this system. Lets the
+  // info map clean up its RequestContexts once all the listeners to the
+  // EXTENSION_UNLOADED notification have finished running.
+  virtual void UnregisterExtensionWithRequestContexts(
+      const std::string& extension_id,
+      const UnloadedExtensionInfo::Reason reason) {}
+
+  // Signaled when the extension system has completed its startup tasks.
+  virtual const OneShotEvent& ready() const = 0;
+};
+
+}  // namespace extensions
+
+#endif  // EXTENSIONS_BROWSER_EXTENSION_SYSTEM_H_