Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 14789008: Move transform building logic out of StyleResolver (Closed)

Created:
7 years, 7 months ago by eae
Modified:
7 years, 7 months ago
Reviewers:
eseidel
CC:
blink-reviews, apavlov+blink_chromium.org, darktears, dglazkov
Visibility:
Public.

Description

Move transform building logic out of StyleResolver Move TransformBuilder::createTransformOperations and support functionality out of StyleResolver and into a separate self contained class. * Source/core/css/StyleResolver.cpp: * Source/core/css/StyleResolver.h: (StyleResolver::applyProperty): Change CSSPropertyWebkitTransform case to use TransformBuilder to populate TransformOperations list. (StyleResolver::parseCustomFilterTransformParam): Change to use TransformBuilder to populate TransformOperations list. (StyleResolver::createTransformOperations): Move createTransformOperations to TransformBuilder. (getTransformOperationType): Move static function to TransformBuilder as it is only used by the createTransformOperations method. * Source/core/css/TransformBuilder.cpp: * Source/core/css/TransformBuilder.h: New files split from StyleResolver, as the cpp file is basically a copy of the relevant section from StyleResolver.cpp the same copyright is used. (convertToFloatLength): Static support function for createTransformOperations. (getTransformOperationType): Static support function for createTransformOperations, moved from StyleResolver.cpp. (TransformBuilder::createTransformOperations): Main method for populating a TransformOperations list, moved from StyleResolver.cpp R=eseidel@chromium.org BUG=237269 TEST=No new tests, no change in functionality. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149545

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+355 lines, -303 lines) Patch
M Source/core/core.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/StyleResolver.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/StyleResolver.cpp View 6 chunks +3 lines, -288 lines 0 comments Download
A + Source/core/css/TransformBuilder.h View 1 chunk +12 lines, -12 lines 0 comments Download
A Source/core/css/TransformBuilder.cpp View 1 chunk +336 lines, -0 lines 0 comments Download
M Source/core/css/WebKitCSSMatrix.cpp View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
eae
I'm not sure why git thinks TransformBuilder.h is a copt of MIDIErrorCallback.h, I suppose they ...
7 years, 7 months ago (2013-05-01 20:57:59 UTC) #1
eseidel
lgtm
7 years, 7 months ago (2013-05-01 22:47:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/14789008/1
7 years, 7 months ago (2013-05-01 22:47:44 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-01 22:50:48 UTC) #4
Message was sent while issue was closed.
Change committed as 149545

Powered by Google App Engine
This is Rietveld 408576698