Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1550)

Unified Diff: chrome/browser/extensions/api/web_request/web_request_apitest.cc

Issue 14788012: ExtensionWebRequestApiTest.PostData* are flaky on Win debug bots (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/web_request/web_request_apitest.cc
diff --git a/chrome/browser/extensions/api/web_request/web_request_apitest.cc b/chrome/browser/extensions/api/web_request/web_request_apitest.cc
index 200e12d83c730b0cfc423a50275cb7061a7b1331..ebc309150f73964eec0e36eb479bc542fb5982f3 100644
--- a/chrome/browser/extensions/api/web_request/web_request_apitest.cc
+++ b/chrome/browser/extensions/api/web_request/web_request_apitest.cc
@@ -245,13 +245,21 @@ IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest,
RunPermissionTest("split", false, false, "redirected1", "");
}
-IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, PostData1) {
+// TODO(vabr): Cure these flaky tests, http://crbug.com/238179.
+#if defined(OS_WIN) && !defined(NDEBUG)
+#define MAYBE_PostData1 DISABLED_PostData1
+#define MAYBE_PostData2 DISABLED_PostData2
+#else
+#define MAYBE_PostData1 PostData1
+#define MAYBE_PostData2 PostData2
+#endif
+IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, MAYBE_PostData1) {
// Test HTML form POST data access with the default and "url" encoding.
ASSERT_TRUE(RunExtensionSubtest("webrequest", "test_post1.html")) <<
message_;
}
-IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, PostData2) {
+IN_PROC_BROWSER_TEST_F(ExtensionWebRequestApiTest, MAYBE_PostData2) {
// Test HTML form POST data access with the multipart and plaintext encoding.
ASSERT_TRUE(RunExtensionSubtest("webrequest", "test_post2.html")) <<
message_;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698