Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3792)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java

Issue 14786021: [rAc Android dialog] Don't show CVC editboxes in drop-down menu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java
index ffa271a31c42ab8b682de5ea8b96cd4b70dc3bdb..8a310d3aa4b77c2f1fdfd3fe48185b6af45ee3d2 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialogContentView.java
@@ -449,7 +449,7 @@ public class AutofillDialogContentView extends LinearLayout {
}
private View initView(
- final int position, View convertView, final ViewGroup parent, boolean showButton) {
+ final int position, View convertView, final ViewGroup parent, boolean isDropDown) {
if (convertView == null) {
convertView = View.inflate(getContext(), R.layout.autofill_menu_item, null);
}
@@ -481,7 +481,7 @@ public class AutofillDialogContentView extends LinearLayout {
}
if (extraEdit != null) {
- if (!TextUtils.isEmpty(mSuggestionTextExtra)) {
+ if (!isDropDown && !TextUtils.isEmpty(mSuggestionTextExtra)) {
extraEdit.setVisibility(VISIBLE);
extraEdit.setHint(mSuggestionTextExtra);
extraEdit.setCompoundDrawables(
@@ -492,7 +492,7 @@ public class AutofillDialogContentView extends LinearLayout {
}
if (button != null) {
- if (showButton && item.mShowButton) {
+ if (isDropDown && item.mShowButton) {
button.setText(item.mButtonLabelResourceId);
button.setOnClickListener(new OnClickListener() {
// TODO(aruslan): http://crbug.com/236101.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698