Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3808)

Unified Diff: runtime/bin/run_vm_tests.cc

Issue 14786012: Second step towards loading the core library scripts directly from the sources (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/bin/run_vm_tests.cc
===================================================================
--- runtime/bin/run_vm_tests.cc (revision 22290)
+++ runtime/bin/run_vm_tests.cc (working copy)
@@ -8,8 +8,11 @@
#include "vm/benchmark_test.h"
#include "vm/dart.h"
+#include "bin/dartutils.h"
#include "vm/unit_test.h"
+using dart::bin::DartUtils;
Ivan Posva 2013/05/02 21:42:58 No using, please...
siva 2013/05/03 01:58:32 Done.
+
// TODO(iposva, asiva): This is a placeholder for the real unittest framework.
namespace dart {
@@ -104,7 +107,10 @@
dart_argv);
ASSERT(set_vm_flags_success);
const char* err_msg = Dart::InitOnce(NULL, NULL, NULL, NULL,
- NULL, NULL, NULL);
+ DartUtils::OpenFile,
Ivan Posva 2013/05/02 21:42:58 Do we need these here? Can we run the VM tests fro
siva 2013/05/03 01:58:32 There are some basic tests which cannot assume the
+ DartUtils::ReadFile,
+ DartUtils::WriteFile,
+ DartUtils::CloseFile);
ASSERT(err_msg == NULL);
// Apply the filter to all registered tests.
TestCaseBase::RunAll();

Powered by Google App Engine
This is Rietveld 408576698