Symlink test_env.py instead of test_support in preparation of jinja2.

Symlink test_env.py instead of test_support in preparation of jinja2.

Update most components tests to use a test_env.py. In practice, it's exchanging
one symlink (test_support) for another (test_env.py).

R=stip@chromium.org
BUG=

Committed: https://github.com/luci/luci-py/commit/604c40e5fbb5b303830c24a41d7c34e3dbd4252b

[M-A Ruel, 2015-11-25 18:50:49]

The important parts are appengine/components/tool_support/gae_sdk_utils.py and
appengine/components/components/test_env.py.

[M-A Ruel, 2015-11-25 18:52:27]

On 2015/11/25 18:50:49, M-A Ruel wrote:
> The important parts are appengine/components/tool_support/gae_sdk_utils.py and
> appengine/components/components/test_env.py.

Most of the change is replacing symlink test_support for symlink test_env.py.

[ghost stip (do not use), 2015-11-25 20:09:53]

a) split the urlquote thing into a sep CL

b) I get 'bad content' for the last two files. upload failure?

other than that lgtm

https://chromiumcodereview.appspot.com/1478573003/diff/1/appengine/components...
File appengine/components/components/template.py (left):

https://chromiumcodereview.appspot.com/1478573003/diff/1/appengine/components...
appengine/components/components/template.py:68: def _urlquote(s):
????

can you split this to a sep CL

[M-A Ruel, 2015-11-26 02:45:46]

Description was changed from

==========
Follow up jinja2 update.

- Stop GAE SDK from inject old jinja2 library into sys.path.
- This required updating most components tests to use a test_env.py. In
  practice, it's exchanging one symlink (test_support) for another
  (test_env.py).

R=stip@chromium.org
BUG=
==========

to

==========
Symlink test_env.py instead of test_support in preparation of jinja2.

Update most components tests to use a test_env.py. In practice, it's exchanging
one symlink (test_support) for another (test_env.py).

R=stip@chromium.org
BUG=
==========

[M-A Ruel, 2015-11-26 02:46:28]

Description was changed from

==========
Symlink test_env.py instead of test_support in preparation of jinja2.

Update most components tests to use a test_env.py. In practice, it's exchanging
one symlink (test_support) for another (test_env.py).

R=stip@chromium.org
BUG=
==========

to

==========
Symlink test_env.py instead of test_support in preparation of jinja2.

Update most components tests to use a test_env.py. In practice, it's exchanging
one symlink (test_support) for another (test_env.py).

R=stip@chromium.org
BUG=
==========

[M-A Ruel, 2015-11-26 02:47:34]

On 2015/11/25 20:09:53, stip wrote:
> a) split the urlquote thing into a sep CL

Done.

> b) I get 'bad content' for the last two files. upload failure?

There was an issue with symlinks replacing a file, but this time it worked.

I rebased against master instead of against jinja2 CL
(https://codereview.chromium.org/1481573002), as I have trouble running tests.

https://chromiumcodereview.appspot.com/1478573003/diff/1/appengine/components...
File appengine/components/components/template.py (left):

https://chromiumcodereview.appspot.com/1478573003/diff/1/appengine/components...
appengine/components/components/template.py:68: def _urlquote(s):
On 2015/11/25 20:09:53, stip wrote:
> ????
> 
> can you split this to a sep CL

Done.

[M-A Ruel, 2015-11-26 02:48:10]

On 2015/11/26 02:47:34, M-A Ruel wrote:
> On 2015/11/25 20:09:53, stip wrote:
> > a) split the urlquote thing into a sep CL
> 
> Done.
> 
> > b) I get 'bad content' for the last two files. upload failure?
> 
> There was an issue with symlinks replacing a file, but this time it worked.
> 
> I rebased against master instead of against jinja2 CL
> (https://codereview.chromium.org/1481573002), as I have trouble running tests.
> 
>
https://chromiumcodereview.appspot.com/1478573003/diff/1/appengine/components...
> File appengine/components/components/template.py (left):
> 
>
https://chromiumcodereview.appspot.com/1478573003/diff/1/appengine/components...
> appengine/components/components/template.py:68: def _urlquote(s):
> On 2015/11/25 20:09:53, stip wrote:
> > ????
> > 
> > can you split this to a sep CL
> 
> Done.

I have to commit manually because it thinks
appengine/swarming/server/test_env.py is there twice.

[M-A Ruel, 2015-11-26 02:50:04]

Description was changed from

==========
Symlink test_env.py instead of test_support in preparation of jinja2.

Update most components tests to use a test_env.py. In practice, it's exchanging
one symlink (test_support) for another (test_env.py).

R=stip@chromium.org
BUG=
==========

to

==========
Symlink test_env.py instead of test_support in preparation of jinja2.

Update most components tests to use a test_env.py. In practice, it's exchanging
one symlink (test_support) for another (test_env.py).

R=stip@chromium.org
BUG=

Committed:
https://github.com/luci/luci-py/commit/604c40e5fbb5b303830c24a41d7c34e3dbd4252b
==========

[M-A Ruel, 2015-11-26 02:50:05]

Committed patchset #2 (id:20001) manually as
604c40e5fbb5b303830c24a41d7c34e3dbd4252b (presubmit successful).