Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 14785010: Remove a bunch of ApplicationCacheHost functions and parameters we don't use. (Closed)

Created:
7 years, 7 months ago by Nate Chapin
Modified:
7 years, 7 months ago
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Visibility:
Public.

Description

Remove a bunch of ApplicationCacheHost functions and parameters we don't use. BUG=none TEST=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149617

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -114 lines) Patch
M Source/WebKit/chromium/src/ApplicationCacheHost.cpp View 1 5 chunks +5 lines, -46 lines 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 6 chunks +4 lines, -39 lines 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 1 chunk +2 lines, -5 lines 0 comments Download
M Source/core/loader/ResourceLoader.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/loader/ResourceLoader.cpp View 1 4 chunks +1 line, -9 lines 0 comments Download
M Source/core/loader/appcache/ApplicationCacheHost.h View 1 2 chunks +5 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nate Chapin
7 years, 7 months ago (2013-05-01 22:39:05 UTC) #1
eseidel
lgtm You are an amazing man.
7 years, 7 months ago (2013-05-01 22:48:24 UTC) #2
michaeln
lgtm, thank you! You could bin this under BUG=229746 if you want. Might be worth ...
7 years, 7 months ago (2013-05-01 23:05:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/14785010/6001
7 years, 7 months ago (2013-05-02 21:51:18 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-05-02 22:14:25 UTC) #5
Message was sent while issue was closed.
Change committed as 149617

Powered by Google App Engine
This is Rietveld 408576698