Add an installer crash key for the currently installed version.

Add an installer crash key for the currently installed version.

Also move common files from setup and setup_unittest to a shared setup_lib in gyp (needed to get the new file to link).

BUG=558552
Committed: https://crrev.com/276937520cc569718fe1b9a17733d752ee0e7410
Cr-Commit-Position: refs/heads/master@{#362551}

[Joe Mason, 2015-11-27 15:18:06]

Description was changed from

==========
Add an installer crash key for the currently installed version.

BUG=558552
==========

to

==========
Add an installer crash key for the currently installed version.

Also move common files from setup and setup_unittest to a shared setup_lib
(needed to get the new file to link).

BUG=558552
==========

[Joe Mason, 2015-11-27 15:34:32]

joenotcharles@chromium.org changed reviewers:
+ grt@chromium.org

[grt (UTC plus 2), 2015-11-27 19:04:24]

code looks good. i'll wait for the corresponding GN changes to review the .gyp
stuff.

https://codereview.chromium.org/1478273003/diff/1/chrome/installer/setup/inst...
File chrome/installer/setup/installer_crash_reporting.cc (right):

https://codereview.chromium.org/1478273003/diff/1/chrome/installer/setup/inst...
chrome/installer/setup/installer_crash_reporting.cc:14: #include
"chrome/installer/util/installation_state.h"
nit: unused

[Joe Mason, 2015-11-27 22:41:11]

Rebase

[Joe Mason, 2015-11-27 22:41:51]

On 2015/11/27 19:04:24, grt wrote:
> code looks good. i'll wait for the corresponding GN changes to review the .gyp
> stuff.

There aren't any GN changes needed because GN was already split into
lib+exe+unittests.

>
https://codereview.chromium.org/1478273003/diff/1/chrome/installer/setup/inst...
> chrome/installer/setup/installer_crash_reporting.cc:14: #include
> "chrome/installer/util/installation_state.h"
> nit: unused

Done.

[grt (UTC plus 2), 2015-11-30 14:08:45]

code looks good. some gyp tweaks below.

https://codereview.chromium.org/1478273003/diff/20001/chrome/chrome_installer...
File chrome/chrome_installer.gypi (right):

https://codereview.chromium.org/1478273003/diff/20001/chrome/chrome_installer...
chrome/chrome_installer.gypi:213: # GN version: //chrome/installer/setup
?
          # GN version: //chrome/installer/setup:lib

https://codereview.chromium.org/1478273003/diff/20001/chrome/chrome_installer...
chrome/chrome_installer.gypi:227: 'installer/mini_installer/chrome.release',
this isn't an input to setup.exe. i suspect it was put here long ago to fix a
build dependency issue that's since been resolved. please remove it and see how
things go.

https://codereview.chromium.org/1478273003/diff/20001/chrome/chrome_installer...
chrome/chrome_installer.gypi:247: 'conditions': [
remove this block. the shim in a link-time thing, so it doesn't belong on an
intermediary static_library target.

https://codereview.chromium.org/1478273003/diff/20001/chrome/chrome_installer...
chrome/chrome_installer.gypi:272: 'direct_dependent_settings': {
i don't think this is needed. could you try removing it?

[Joe Mason, 2015-11-30 21:12:21]

On 2015/11/30 14:08:45, grt wrote:
> code looks good. some gyp tweaks below.

Worked on all the trybots. The one android failure seems to be unrelated
flakiness (file not found building telemetry_perf_unittests)

[grt (UTC plus 2), 2015-11-30 22:11:56]

right on. lgtm.

[Joe Mason, 2015-12-01 16:28:39]

The CQ bit was checked by joenotcharles@chromium.org

[commit-bot: I haz the power, 2015-12-01 16:29:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-01 16:29:46]

This CL has an open dependency (Issue 1481933002 Patch 160001). Please resolve
the dependency and try again.

[Joe Mason, 2015-12-01 18:02:15]

The CQ bit was checked by joenotcharles@chromium.org

[commit-bot: I haz the power, 2015-12-01 18:03:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1478273003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1478273003/60001

[commit-bot: I haz the power, 2015-12-01 18:11:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-01 18:11:02]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Joe Mason, 2015-12-01 21:07:41]

Description was changed from

==========
Add an installer crash key for the currently installed version.

Also move common files from setup and setup_unittest to a shared setup_lib
(needed to get the new file to link).

BUG=558552
==========

to

==========
Add an installer crash key for the currently installed version.

Also move common files from setup and setup_unittest to a shared setup_lib in
gyp (needed to get the new file to link).

BUG=558552
==========

[Joe Mason, 2015-12-01 21:09:55]

The CQ bit was checked by joenotcharles@chromium.org

[Joe Mason, 2015-12-01 21:09:56]

The patchset sent to the CQ was uploaded after l-g-t-m from grt@chromium.org
Link to the patchset: https://codereview.chromium.org/1478273003/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2015-12-01 21:11:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1478273003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1478273003/80001

[commit-bot: I haz the power, 2015-12-01 22:36:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-01 22:36:13]

Internal error: failed to checkout. Please try again.

[commit-bot: I haz the power, 2015-12-01 22:37:22]

The CQ bit was unchecked by commit-bot@chromium.org

[Joe Mason, 2015-12-01 22:39:51]

The CQ bit was checked by joenotcharles@chromium.org

[commit-bot: I haz the power, 2015-12-01 22:42:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1478273003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1478273003/80001

[commit-bot: I haz the power, 2015-12-01 23:54:12]

Description was changed from

==========
Add an installer crash key for the currently installed version.

Also move common files from setup and setup_unittest to a shared setup_lib in
gyp (needed to get the new file to link).

BUG=558552
==========

to

==========
Add an installer crash key for the currently installed version.

Also move common files from setup and setup_unittest to a shared setup_lib in
gyp (needed to get the new file to link).

BUG=558552
==========

[commit-bot: I haz the power, 2015-12-01 23:54:13]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-12-01 23:54:58]

Description was changed from

==========
Add an installer crash key for the currently installed version.

Also move common files from setup and setup_unittest to a shared setup_lib in
gyp (needed to get the new file to link).

BUG=558552
==========

to

==========
Add an installer crash key for the currently installed version.

Also move common files from setup and setup_unittest to a shared setup_lib in
gyp (needed to get the new file to link).

BUG=558552

Committed: https://crrev.com/276937520cc569718fe1b9a17733d752ee0e7410
Cr-Commit-Position: refs/heads/master@{#362551}
==========

[commit-bot: I haz the power, 2015-12-01 23:54:59]

Patchset 5 (id:??) landed as
https://crrev.com/276937520cc569718fe1b9a17733d752ee0e7410
Cr-Commit-Position: refs/heads/master@{#362551}