Issue 14780004: [Telemetry] Escape URLs in "Pages:" list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14780004: [Telemetry] Escape URLs in "Pages:" list. (Closed)

Created:
7 years, 7 months ago by tonyg

Modified:
7 years, 7 months ago

Reviewers:
bulach, dtu

CC:
chromium-reviews, craigdh+watch_chromium.org, chrome-speed-team+watch_google.com, bulach+watch_chromium.org, yfriedman+watch_chromium.org, klundberg+watch_chromium.org, telemetry+watch_chromium.org, ilevy+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Telemetry] Escape URLs in "Pages:" list. They must match the trace names printed by PrintPerfResult, which are also escaped with the same method. This patch allows the buildbot log processor to work with the updated page cyclers. BUG=None TEST=tools/perf/run_multipage_benchmarks --browser=system page_cycler tools/perf/page_sets/intl_es_fr_pt-BR.json --pageset-repeat=2 NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198765

Patch Set 1 #

Patch Set 2 : Also escape commas #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
M	build/android/pylib/perf_tests_helper.py	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	tools/telemetry/telemetry/page/page_measurement_results.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/telemetry/telemetry/page/perf_tests_helper.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bulach

lgtm, thanks! (we should move this out of android and into telemetry at some point...)

7 years, 7 months ago (2013-05-07 17:54:58 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tonyg@chromium.org/14780004/3001

7 years, 7 months ago (2013-05-07 17:58:00 UTC) #3

tonyg

> (we should move this out of android and into telemetry at some point...) agreed

7 years, 7 months ago (2013-05-07 17:58:08 UTC) #4

Message was sent while issue was closed.

Change committed as 198765

Expand Messages | Collapse Messages