Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 14779006: [Android] Fix issues with textwatchers in AutofillDialog. (Closed)

Created:
7 years, 7 months ago by aurimas (slooooooooow)
Modified:
7 years, 7 months ago
Reviewers:
Ted C
CC:
chromium-reviews, Raman Kakilate, benquan, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman
Visibility:
Public.

Description

[Android] Fix issues with textwatchers in AutofillDialog. The text watcher was not being removed correctly when switching from one EditText to another in AutofillDialog editing layout. Incorrect editedOrActivatedField() calls were being sent out. BUG=237750 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198795

Patch Set 1 #

Patch Set 2 : Undo deleting a new line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -15 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/autofill/AutofillDialog.java View 1 4 chunks +26 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
aurimas (slooooooooow)
Hey Ted! Please take a look at this CL! Aurimas
7 years, 7 months ago (2013-05-07 16:19:27 UTC) #1
Ted C
lgtm
7 years, 7 months ago (2013-05-07 16:35:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/14779006/1002
7 years, 7 months ago (2013-05-07 21:01:06 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-07 21:01:40 UTC) #4
Message was sent while issue was closed.
Change committed as 198795

Powered by Google App Engine
This is Rietveld 408576698