Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 14776012: Exclude background-repeat from comprasion when styling the controls. (Closed)

Created:
7 years, 7 months ago by mrunal
Modified:
7 years, 6 months ago
Reviewers:
haraken, tkent
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Exclude background-repeat from comprasion when styling the controls. This helps it retain native styling. BUG=229683 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151537

Patch Set 1 #

Patch Set 2 : Exclude background-repeat from comprasion when styling the controls. #

Patch Set 3 : Exclude background-repeat from comprasion when styling the controls. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
A LayoutTests/fast/forms/background-repeat-no-repeat.html View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
A + LayoutTests/fast/forms/background-repeat-no-repeat-expected.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/rendering/RenderTheme.cpp View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 19 (0 generated)
mrunal
Can someone take a look please?
7 years, 7 months ago (2013-05-15 01:27:28 UTC) #1
tkent
We need a test. It should be a ref test comparing a button with background-repeat ...
7 years, 7 months ago (2013-05-15 02:09:15 UTC) #2
mrunal
Ok, I will add a test.
7 years, 7 months ago (2013-05-15 18:17:16 UTC) #3
mrunal
I have added the RefTest. PTAL.
7 years, 6 months ago (2013-05-29 23:45:38 UTC) #4
tkent
Please put the test to LayoutTests/fast/forms/. It tests a RenderTheme (very related to Forms) behavior, ...
7 years, 6 months ago (2013-05-29 23:52:36 UTC) #5
mrunal
On 2013/05/29 23:52:36, tkent wrote: > Please put the test to LayoutTests/fast/forms/. It tests a ...
7 years, 6 months ago (2013-05-30 00:10:48 UTC) #6
tkent
lgtm
7 years, 6 months ago (2013-05-30 00:38:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mrunal.kapade@intel.com/14776012/10001
7 years, 6 months ago (2013-05-30 00:39:00 UTC) #8
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=7601
7 years, 6 months ago (2013-05-30 04:59:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mrunal.kapade@intel.com/14776012/10001
7 years, 6 months ago (2013-05-30 05:02:11 UTC) #10
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=7645
7 years, 6 months ago (2013-05-30 08:30:27 UTC) #11
mrunal
Hmmm...don't understand why this failed. I'm not much familiar at looking into layout test logs. ...
7 years, 6 months ago (2013-05-30 19:06:40 UTC) #12
tkent
Commit-queue is unstable these days. Let's try again.
7 years, 6 months ago (2013-05-30 21:08:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mrunal.kapade@intel.com/14776012/10001
7 years, 6 months ago (2013-05-30 21:08:22 UTC) #14
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=7884
7 years, 6 months ago (2013-05-31 00:35:26 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mrunal.kapade@intel.com/14776012/10001
7 years, 6 months ago (2013-05-31 03:55:54 UTC) #16
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=7961
7 years, 6 months ago (2013-05-31 05:48:39 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mrunal.kapade@intel.com/14776012/10001
7 years, 6 months ago (2013-05-31 06:31:39 UTC) #18
commit-bot: I haz the power
7 years, 6 months ago (2013-05-31 08:56:03 UTC) #19
Message was sent while issue was closed.
Change committed as 151537

Powered by Google App Engine
This is Rietveld 408576698