Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1775)

Unified Diff: chrome/browser/extensions/activity_log/api_actions.h

Issue 14774012: Replaced enum strings with ints in Activity Log database (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Added missing Singleton dep Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/activity_log/api_actions.h
diff --git a/chrome/browser/extensions/activity_log/api_actions.h b/chrome/browser/extensions/activity_log/api_actions.h
index 2a5ff4b69be1684751b835a54fa46812cd106ab6..3744f52380af81e41b5dfc21fc379a8a2d5ba37f 100644
--- a/chrome/browser/extensions/activity_log/api_actions.h
+++ b/chrome/browser/extensions/activity_log/api_actions.h
@@ -14,14 +14,17 @@ namespace extensions {
// problems. See BlockedActions for API calls that did not succeed.
class APIAction : public Action {
public:
+ // These values should not be changed. Append any additional values to the
+ // end with sequential numbers.
enum Type {
- CALL,
- EVENT_CALLBACK,
- UNKNOWN_TYPE
+ CALL = 0,
+ EVENT_CALLBACK = 1,
+ UNKNOWN_TYPE = 2,
};
static const char* kTableName;
static const char* kTableContentFields[];
+ static const char* kTableFieldTypes[];
static const char* kAlwaysLog[];
static const int kSizeAlwaysLog;
@@ -61,9 +64,6 @@ class APIAction : public Action {
std::string TypeAsString() const;
std::string extra() const { return extra_; }
- // Helper method(s) for creating a APIAction.
- static Type StringAsType(const std::string& str);
-
protected:
virtual ~APIAction();

Powered by Google App Engine
This is Rietveld 408576698