Fix imageburner trying to extract downloaded image to unexisting folder.

Fix imageburner trying to extract downloaded image to unexisting folder.

BUG=239330
TEST=burned recovery image using chrome://imageburner

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199450

[achuithb, 2013-05-09 21:52:51]

https://codereview.chromium.org/14773024/diff/1/chrome/browser/chromeos/image...
File chrome/browser/chromeos/imageburner/burn_manager.h (right):

https://codereview.chromium.org/14773024/diff/1/chrome/browser/chromeos/image...
chrome/browser/chromeos/imageburner/burn_manager.h:326: // Returns directory
image should be dopwnloaded to.
nit: can we fix the spelling of dopwnloaded

https://codereview.chromium.org/14773024/diff/1/chrome/browser/chromeos/image...
chrome/browser/chromeos/imageburner/burn_manager.h:327: // The directory has to
be previously created.
Maybe this comment should be changed to say that empty path is returned if
directory creation failed?

https://codereview.chromium.org/14773024/diff/1/chrome/browser/chromeos/image...
chrome/browser/chromeos/imageburner/burn_manager.h:328: const base::FilePath
GetImageDir();
Don't see the point of const since this will be copied anyway?

[tbarzic, 2013-05-09 22:11:38]

https://codereview.chromium.org/14773024/diff/1/chrome/browser/chromeos/image...
File chrome/browser/chromeos/imageburner/burn_manager.h (right):

https://codereview.chromium.org/14773024/diff/1/chrome/browser/chromeos/image...
chrome/browser/chromeos/imageburner/burn_manager.h:326: // Returns directory
image should be dopwnloaded to.
On 2013/05/09 21:52:51, achuith.bhandarkar wrote:
> nit: can we fix the spelling of dopwnloaded

Done.

https://codereview.chromium.org/14773024/diff/1/chrome/browser/chromeos/image...
chrome/browser/chromeos/imageburner/burn_manager.h:327: // The directory has to
be previously created.
On 2013/05/09 21:52:51, achuith.bhandarkar wrote:
> Maybe this comment should be changed to say that empty path is returned if
> directory creation failed?

Done.

https://codereview.chromium.org/14773024/diff/1/chrome/browser/chromeos/image...
chrome/browser/chromeos/imageburner/burn_manager.h:328: const base::FilePath
GetImageDir();
On 2013/05/09 21:52:51, achuith.bhandarkar wrote:
> Don't see the point of const since this will be copied anyway?

Done.

[achuithb, 2013-05-09 22:22:13]

lgtm

[commit-bot: I haz the power, 2013-05-09 22:46:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tbarzic@chromium.org/14773024/2002

[commit-bot: I haz the power, 2013-05-10 10:48:40]

Change committed as 199450