Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: chrome/browser/android/resource_mapper.cc

Issue 14772036: Let Android port access properly sized images (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing comments Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/resource_mapper.cc
diff --git a/chrome/browser/android/resource_mapper.cc b/chrome/browser/android/resource_mapper.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a7db2627b5ba1333f6c1acb11a7e7aae48dc15db
--- /dev/null
+++ b/chrome/browser/android/resource_mapper.cc
@@ -0,0 +1,40 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/android/resource_mapper.h"
+
+#include <map>
+
+#include "base/logging.h"
+#include "grit/theme_resources.h"
+
+const int ResourceMapper::kMissingId = -1;
+
+namespace {
+ std::map<int, int> g_id_map;
Yaron 2013/05/20 20:54:25 Don't indent scope under namespace
gone 2013/05/20 21:28:04 Done.
+
+ // Create the mapping. IDs start at 0 to correspond to the array that gets
+ // built in the corresponding ResourceID Java class.
+ void ConstructMap() {
+ int next_id = 0;
Yaron 2013/05/20 20:54:25 How about DCHECK(g_id_map.empty());
gone 2013/05/20 21:28:04 Done.
+#define DEFINE_RESOURCE_ID(c_id,java_id) g_id_map[c_id] = next_id++;
+#include "chrome/browser/android/resource_id.h"
+#undef DEFINE_RESOURCE_ID
+ }
+}
Yaron 2013/05/20 20:54:25 // namespace
gone 2013/05/20 21:28:04 Done.
+
+int ResourceMapper::MapFromChromiumId(int resource_id) {
+ if (g_id_map.empty()) {
+ ConstructMap();
+ }
+
+ std::map<int, int>::iterator iterator = g_id_map.find(resource_id);
+ if (iterator != g_id_map.end()) {
+ return iterator->second;
+ }
+
+ // The resource couldn't be found.
+ NOTREACHED();
+ return kMissingId;
+}

Powered by Google App Engine
This is Rietveld 408576698