Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14772013: Fix a broken ASSERT in StylePropertySerializer. (Closed)

Created:
7 years, 7 months ago by darktears
Modified:
7 years, 7 months ago
Reviewers:
eseidel
CC:
Hans Muller, blink-reviews, apavlov+blink_chromium.org, darktears
Visibility:
Public.

Description

Fix a broken ASSERT in StylePropertySerializer. We may reach that function asking for a disabled property. It was too aggressive to put it here. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149728

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M Source/core/css/StylePropertySerializer.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
darktears
7 years, 7 months ago (2013-05-03 22:51:05 UTC) #1
eseidel
lgtm
7 years, 7 months ago (2013-05-03 22:53:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/14772013/1
7 years, 7 months ago (2013-05-03 22:53:33 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=6649
7 years, 7 months ago (2013-05-04 03:06:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/14772013/1
7 years, 7 months ago (2013-05-04 05:42:32 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=6688
7 years, 7 months ago (2013-05-04 06:12:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/14772013/1
7 years, 7 months ago (2013-05-04 06:18:06 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=6694
7 years, 7 months ago (2013-05-04 06:47:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/14772013/1
7 years, 7 months ago (2013-05-06 13:09:04 UTC) #9
commit-bot: I haz the power
7 years, 7 months ago (2013-05-06 13:20:08 UTC) #10
Message was sent while issue was closed. 
Change committed as 149728

Powered by Google App Engine
This is Rietveld 408576698