Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 14772009: Rationalize dependency on khronos EGL headers in place of angle. (Closed)

Created:
7 years, 7 months ago by rjkroege
Modified:
7 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Rationalize dependency on khronos EGL headers in place of angle. Different parts of Chrome use the angle EGL headers and khronos EGL headers. This patch adjusts so that Chrome uses only one: khronos. BUG=none, code cleanup Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199773

Patch Set 1 #

Patch Set 2 : updated khronos headers. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M content/content_common.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
M content/content_gpu.gypi View 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer_service.gypi View 1 chunk +1 line, -1 line 0 comments Download
M third_party/khronos/EGL/eglext.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M ui/gl/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/egl_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gl/gl.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/gl/gl_context_egl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/surface/surface.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
rjkroege
Hi Ken, This is my first cut at what we discussed yesterday: khronos headers everywhere. ...
7 years, 7 months ago (2013-05-01 19:57:46 UTC) #1
Ken Russell (switch to Gerrit)
+apatrick,gman,jamesr Thanks for working on this. It's been an area of confusion for a long ...
7 years, 7 months ago (2013-05-01 20:12:20 UTC) #2
greggman
lgtm
7 years, 7 months ago (2013-05-01 22:16:27 UTC) #3
rjkroege
On 2013/05/01 22:16:27, greggman wrote: > lgtm the mac_asan fail looks like flake to me. ...
7 years, 7 months ago (2013-05-03 15:19:09 UTC) #4
Ken Russell (switch to Gerrit)
LGTM
7 years, 7 months ago (2013-05-03 17:24:29 UTC) #5
rjkroege
+jam for OWNERS on content/content_common
7 years, 7 months ago (2013-05-03 17:38:12 UTC) #6
jam
lgtm
7 years, 7 months ago (2013-05-03 18:19:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjkroege@chromium.org/14772009/11001
7 years, 7 months ago (2013-05-03 18:25:34 UTC) #8
commit-bot: I haz the power
Retried try job too often on ios_rel_device for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_rel_device&number=46764
7 years, 7 months ago (2013-05-03 18:42:27 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rjkroege@chromium.org/14772009/11001
7 years, 7 months ago (2013-05-13 15:54:41 UTC) #10
commit-bot: I haz the power
7 years, 7 months ago (2013-05-13 18:24:40 UTC) #11
Message was sent while issue was closed.
Change committed as 199773

Powered by Google App Engine
This is Rietveld 408576698