Issue 14767015: Also check .cpp files for include rules violations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14767015: Also check .cpp files for include rules violations (Closed)

Created:
7 years, 7 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 7 months ago

Reviewers:
eseidel

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Also check .cpp files for include rules violations This is to prepare checkdeps for usage in blink Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198529

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	tools/checkdeps/cpp_checker.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

eseidel

lgtm I suspect this is OWNERS=*, but if it's not, you'll need someone else to ...

7 years, 7 months ago (2013-05-06 09:28:53 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/14767015/1

7 years, 7 months ago (2013-05-06 09:29:01 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/14767015/1

7 years, 7 months ago (2013-05-06 19:47:47 UTC) #3

Message was sent while issue was closed.

Change committed as 198529