media/capture/content/thread_safe_capture_oracle.cc - Issue 1476523005: Verify returned frames from media::VideoFrame::Wrap*() methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/capture/content/thread_safe_capture_oracle.cc

Issue 1476523005: Verify returned frames from media::VideoFrame::Wrap*() methods (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: halliwell@ comments. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/capture/content/thread_safe_capture_oracle.cc

diff --git a/media/capture/content/thread_safe_capture_oracle.cc b/media/capture/content/thread_safe_capture_oracle.cc

index a99a99a16b17ca711e2762683bd17c386194a718..f3ba5a428de864e26e721086452ed9869aa929fe 100644

--- a/media/capture/content/thread_safe_capture_oracle.cc

+++ b/media/capture/content/thread_safe_capture_oracle.cc

@@ -122,7 +122,8 @@ bool ThreadSafeCaptureOracle::ObserveEventAndDecideCapture(

static_cast<uint8_t*>(output_buffer->data()),

output_buffer->mapped_size(), base::SharedMemory::NULLHandle(), 0u,

base::TimeDelta());

- DCHECK(*storage);

+ if (!(*storage))

+ return false;

*callback =

base::Bind(&ThreadSafeCaptureOracle::DidCaptureFrame, this, frame_number,

base::Passed(&output_buffer), capture_begin_time,

« no previous file with comments | « media/base/video_frame.cc ('k') | media/cast/test/fake_media_source.cc » ('j') | no next file with comments »