Verify returned frames from media::VideoFrame::Wrap*() methods

content/common/gpu/media/v4l2_image_processor.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <errno.h>
 #include <fcntl.h>
 #include <linux/videodev2.h>
 #include <poll.h>
 #include <string.h>
 #include <sys/eventfd.h>
@@ skipping 543 matching lines @@
     running_jobs_.pop();
 
     scoped_refptr<media::VideoFrame> output_frame =
         media::VideoFrame::WrapExternalDmabufs(
             output_format_,
             output_allocated_size_,
             gfx::Rect(output_visible_size_),
             output_visible_size_,
             output_record.fds,
             job_record->frame->timestamp());
+    if (!output_frame)
+      continue;

[Pawel Osciak, 2016/01/13 07:53:25]

We should NOTIFY_ERROR from here instead. Otherwise we are dropping the buffer
and will stall eventually.

[emircan, 2016/01/14 23:13:53]

Changing to NOTIFY_ERROR and return. The logs would come from video_frame.cc.

     output_frame->AddDestructionObserver(media::BindToCurrentLoop(
         base::Bind(&V4L2ImageProcessor::ReuseOutputBuffer,
                    device_weak_factory_.GetWeakPtr(),
                    dqbuf.index)));
 
     DVLOG(3) << "Processing finished, returning frame, ts="
              << output_frame->timestamp().InMilliseconds();
 
     child_task_runner_->PostTask(
         FROM_HERE, base::Bind(job_record->ready_cb, output_frame));
@@ skipping 144 matching lines @@
     output_record.at_device = false;
     if (!output_record.at_client)
       free_output_buffers_.push_back(i);
   }
   output_buffer_queued_count_ = 0;
 
   return true;
 }
 
 }  // namespace content