Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1476323002: Add base to "gn check". (Closed)

Created:
5 years ago by brettw
Modified:
5 years ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, wfh+watch_chromium.org, Dai Mikurube (NOT FULLTIME), asvitkine+watch_chromium.org, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add base to "gn check". This fixes some dependency warnings on Windows. TBR=dpranke Committed: https://crrev.com/29c2f89d59163857e29841ecf30aa1601b1efb6e Cr-Commit-Position: refs/heads/master@{#362015}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -15 lines) Patch
M .gn View 1 chunk +1 line, -1 line 0 comments Download
M base/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M base/allocator/BUILD.gn View 1 2 chunks +2 lines, -1 line 0 comments Download
M base/debug/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M base/metrics/BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download
M base/trace_event/BUILD.gn View 1 2 2 chunks +11 lines, -11 lines 0 comments Download

Messages

Total messages: 22 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476323002/1
5 years ago (2015-11-26 18:36:01 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/35459)
5 years ago (2015-11-26 18:39:53 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476323002/20001
5 years ago (2015-11-26 19:22:56 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/163232) linux_chromium_compile_dbg_ng on ...
5 years ago (2015-11-26 19:26:18 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476323002/40001
5 years ago (2015-11-26 19:34:03 UTC) #10
brettw
5 years ago (2015-11-26 20:12:35 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-11-26 21:10:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1476323002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1476323002/40001
5 years ago (2015-11-27 16:58:18 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years ago (2015-11-27 17:03:55 UTC) #19
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/29c2f89d59163857e29841ecf30aa1601b1efb6e Cr-Commit-Position: refs/heads/master@{#362015}
5 years ago (2015-11-27 17:04:49 UTC) #21
Dirk Pranke
5 years ago (2015-11-29 18:32:28 UTC) #22
Message was sent while issue was closed. 
lgtm.

Powered by Google App Engine
This is Rietveld 408576698